feat(http1): support configurable max_headers#3523
Merged
seanmonstar merged 2 commits intohyperium:masterfrom Jan 25, 2024
Merged
feat(http1): support configurable max_headers#3523seanmonstar merged 2 commits intohyperium:masterfrom
max_headers#3523seanmonstar merged 2 commits intohyperium:masterfrom
Conversation
seanmonstar
requested changes
Jan 12, 2024
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Thanks for the thorough PR! I welcome adding the option, but I want to make sure we continue to stay as fast as possible.
|
We encountered an issue that requires this as well, thanks for sending PR! would love to help if needed :) |
yukiiiteru
force-pushed
the
dyn-header-size
branch
from
f6015e3 to
fed4520
Compare
seanmonstar
reviewed
Jan 24, 2024
Signed-off-by: Yu Li <[email protected]>
Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
dyn-header-size
branch
from
fed4520 to
24bef8e
Compare
IvanGoncharov
pushed a commit
to apollographql/hyper
that referenced
this pull request
Oct 23, 2024
IvanGoncharov
added a commit
to apollographql/hyper
that referenced
this pull request
Oct 23, 2024
Backport hyperium#3523 to 0.14.x.
IvanGoncharov
pushed a commit
to apollographql/hyper
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we encountered a problem when using
hyper.After the client sent the request, it received response
431 Request Header Fields Too Large. After investigation, we found thathypersets an upper limit on the number ofheaders, and this upper limit is a fixed and non-configurable value.#3283 also encountered similar problems.
This PR sets
max_headersto a configurable value. Its default value remains the same as the previous code, and we can set this value when needed.Additionally, unit tests have been added and the current code passes.