Adapt circuit-breaker component to support php8.#3694
Merged
limingxinleo merged 3 commits intohyperf:2.2from Jun 11, 2021
Merged
Adapt circuit-breaker component to support php8.#3694limingxinleo merged 3 commits intohyperf:2.2from
limingxinleo merged 3 commits intohyperf:2.2from
Conversation
huangzhhui
reviewed
Jun 13, 2021
| } | ||
|
|
||
| public function incFailCounter(): int | ||
| public function incrFailCounter(): int |
huangzhhui
reviewed
Jun 13, 2021
| } | ||
|
|
||
| protected function switch(CircuitBreaker $breaker, Annotation $annotation, bool $status) | ||
| protected function switch(CircuitBreakerInterface $breaker, Annotation $annotation, bool $status): void |
Member
There was a problem hiding this comment.
这个 Typehint 的改动应该也是需要在 changelog 标记出来的
Member
Author
|
嗯，我后面加上 |
limingxinleo
added a commit
to limingxinleo/hyperf
that referenced
this pull request
Jun 15, 2021
limingxinleo
added a commit
to limingxinleo/hyperf
that referenced
this pull request
Jun 15, 2021
limingxinleo
added a commit
to limingxinleo/hyperf
that referenced
this pull request
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.