Use Fork Process strategy to replace BetterReflection strategy#3634
Merged
assert6 merged 18 commits intohyperf:2.2from May 31, 2021
Merged
Use Fork Process strategy to replace BetterReflection strategy#3634assert6 merged 18 commits intohyperf:2.2from
assert6 merged 18 commits intohyperf:2.2from
Conversation
huangzhhui
changed the title
Contributor
|
mark |
# Conflicts: # composer.json # src/di/src/ClassLoader.php
| return $classes; | ||
| // Get the class map of Composer loader | ||
| $classMap = array_merge($reflectionClassMap, $classMap); | ||
| $proxyManager = new ProxyManager($classMap, $proxyDir); |
Member
There was a problem hiding this comment.
这个 ProxyManager 也必须要在子进程里完成么？
Member
Author
There was a problem hiding this comment.
对, Ast 生成代理文件时用了Reflection
… 2.2-develope � Conflicts: � src/di/src/Annotation/Inject.php � src/di/tests/InjectTest.php
limingxinleo
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.