统一了 kafka 消费者和生产者都是用 brokers 的配置,移除消费者的 broker 配置#3550
Merged
limingxinleo merged 10 commits intohyperf:2.2from Jun 22, 2021
Merged
统一了 kafka 消费者和生产者都是用 brokers 的配置,移除消费者的 broker 配置#3550limingxinleo merged 10 commits intohyperf:2.2from
limingxinleo merged 10 commits intohyperf:2.2from
Conversation
Contributor
|
这里也得把 consumer 里的 bootstrap_servers 加上，否则，如果只设置了 bootstrap_server 的情况下，consumer 中 parse_url 会报错 |
Contributor
|
@limingxinleo 这个 PR 看看能不能合到 2.2 中来吧，个人觉得挺合理、有用的 |
Member
|
应该会的，2.2 里会重构一部分 kafka 的代码 |
limingxinleo
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.