Skip to content

保持 LengthAwarePaginator 与 Paginator 返回一致#3334

Merged
limingxinleo merged 4 commits intohyperf:2.2from
GanymedeNil:lengthAwarePaginator_fix
Jun 4, 2021
Merged

保持 LengthAwarePaginator 与 Paginator 返回一致#3334
limingxinleo merged 4 commits intohyperf:2.2from
GanymedeNil:lengthAwarePaginator_fix

Conversation

@GanymedeNil
Copy link
Copy Markdown
Contributor

No description provided.

@limingxinleo
Copy link
Copy Markdown
Member

为什么要改动这里??

@limingxinleo
Copy link
Copy Markdown
Member

这两个逻辑上就是不一样

image

image

@limingxinleo limingxinleo added the reviewing Reviewing a pull request label Mar 5, 2021
@GanymedeNil
Copy link
Copy Markdown
Contributor Author

GanymedeNil commented Mar 6, 2021

@limingxinleo

Paginator

image
返回结构
image

LengthAwarePaginator

image
现在返回是这样的
image
我认为应该返回的结构
image

@limingxinleo
Copy link
Copy Markdown
Member

好像是会有这个问题,但这个改动会导致 BC

@limingxinleo limingxinleo requested a review from huangzhhui March 6, 2021 10:10
@limingxinleo limingxinleo added the BC Break Change label Mar 6, 2021
@limingxinleo limingxinleo added this to the v3.0 milestone Mar 12, 2021
@limingxinleo limingxinleo changed the base branch from master to 2.2 June 4, 2021 16:04
@limingxinleo limingxinleo merged commit c0baa40 into hyperf:2.2 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC Break Change reviewing Reviewing a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants