Skip to content

Assert the binding values for database by default.#3174

Merged
limingxinleo merged 9 commits intohyperf:masterfrom
nfangxu:fix-query-bindings-with-array
Jan 22, 2021
Merged

Assert the binding values for database by default.#3174
limingxinleo merged 9 commits intohyperf:masterfrom
nfangxu:fix-query-bindings-with-array

Conversation

@nfangxu
Copy link
Copy Markdown
Contributor

@nfangxu nfangxu commented Jan 21, 2021

@huangzhhui @limingxinleo 看下 参考了 laravel 那边的处理方式 但是使用递归处理更深层次的数组

@nfangxu nfangxu changed the title Fix query bindings with array Limit expected bindings Jan 21, 2021
@limingxinleo
Copy link
Copy Markdown
Member

我还是觉得,应该是用户自己处理。。。

@limingxinleo
Copy link
Copy Markdown
Member

image

我觉得直接抛出异常更加合理。。为啥要强行为用户的错误使用买单呢?

@huangzhhui @nfangxu

@limingxinleo limingxinleo changed the title Limit expected bindings Assert the binding values for database Jan 22, 2021
@limingxinleo limingxinleo changed the title Assert the binding values for database Assert the binding values for database by default. Jan 22, 2021
@limingxinleo limingxinleo merged commit 429d317 into hyperf:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants