fix: fix grpc-client streaming#2490
Merged
limingxinleo merged 8 commits intohyperf:masterfrom Sep 21, 2020
Merged
Conversation
Reasno
requested review from
huangzhhui and
limingxinleo
and removed request for
huangzhhui
Member
Author
|
streaming的时候 如果连接断了 swoole/grpc的官方实现是返回false，我这里和官方保持了一致，但是可以考虑是不是抛出异常更好一些？ |
This was
linked to
issues
Sep 12, 2020
2 tasks
Reasno
force-pushed
the
grpc-client-streaming
branch
from
5d1752b to
8b7182d
Compare
Reasno
force-pushed
the
grpc-client-streaming
branch
2 times, most recently
from
5b3d8cf to
7ee24a2
Compare
Reasno
force-pushed
the
grpc-client-streaming
branch
from
7ee24a2 to
b30f33f
Compare
| Message $argument, | ||
| $deserialize | ||
| $deserialize, | ||
| array $metadata = [], |
Member
There was a problem hiding this comment.
这个 metadata 好像没用到啊。。
是预留的么？
Member
There was a problem hiding this comment.
如果后面可能有用，就预留放着吧，没必要删掉。。
我看其他几个 request 方法，也都有
| * @param mixed $data | ||
| */ | ||
| public function openStream(string $path, string $data = null): int | ||
| public function openStream(string $path, $data = '', string $method = '', bool $usePipelineRead = false): int |
Member
There was a problem hiding this comment.
这里为啥把 string 约束去掉。。如果说支持输入 null
改成 ?string 是不是会好点
limingxinleo
previously approved these changes
Sep 17, 2020
limingxinleo
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.