Merge pull request #1092 from hydephp/minor-compatible-schema-interface-updates

emmadesilva · web-flow · commit f2ac3c8a7cba · 2023-02-21T20:58:32.000+01:00
Minor compatible schema interface updates
diff --git a/packages/framework/src/Markdown/Contracts/FrontMatter/SubSchemas/FeaturedImageSchema.php b/packages/framework/src/Markdown/Contracts/FrontMatter/SubSchemas/FeaturedImageSchema.php
@@ -12,7 +12,7 @@ interface FeaturedImageSchema
 {
     public const FEATURED_IMAGE_SCHEMA = [
         'path'           => 'string',
-        'url'            => 'string',
+        'url'            => 'string', // Takes precedence over path
         'description'    => 'string',
         'title'          => 'string',
         'copyright'      => 'string',
diff --git a/packages/framework/tests/Unit/SchemaContractsTest.php b/packages/framework/tests/Unit/SchemaContractsTest.php
@@ -7,7 +7,7 @@
 use Hyde\Markdown\Contracts\FrontMatter\BlogPostSchema;
 use Hyde\Markdown\Contracts\FrontMatter\PageSchema;
 use Hyde\Markdown\Contracts\FrontMatter\SubSchemas\NavigationSchema;
-use Hyde\Testing\TestCase;
+use PHPUnit\Framework\TestCase;
 
 /**
  * A state test to ensure the schemas can't be changed without breaking the tests.

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ interface FeaturedImageSchema`
`12`	`12`	`{`
`13`	`13`	`public const FEATURED_IMAGE_SCHEMA = [`
`14`	`14`	`'path' => 'string',`
`15`		`- 'url' => 'string',`
	`15`	`+ 'url' => 'string', // Takes precedence over path`
`16`	`16`	`'description' => 'string',`
`17`	`17`	`'title' => 'string',`
`18`	`18`	`'copyright' => 'string',`