Merge pull request #1056 from hydephp/refactor-hydefront-versioning

emmadesilva · web-flow · commit e25554d15ca4 · 2023-02-16T22:02:01.000+01:00
Add "hidden" configuration option for setting the HydeFront version
diff --git a/packages/framework/src/Framework/Services/AssetService.php b/packages/framework/src/Framework/Services/AssetService.php
@@ -24,6 +24,13 @@ class AssetService
      */
     public string $version = 'v2.0';
 
+    public function __construct()
+    {
+        if (config('hyde.hydefront_version')) {
+            $this->version = config('hyde.hydefront_version');
+        }
+    }
+
     public function version(): string
     {
         return $this->version;
diff --git a/packages/framework/tests/Feature/AssetServiceTest.php b/packages/framework/tests/Feature/AssetServiceTest.php
@@ -32,6 +32,13 @@ public function test_version_method_returns_version_property_when_config_overrid
         $this->assertEquals($service->version, $service->version());
     }
 
+    public function test_version_can_be_set_in_config()
+    {
+        config(['hyde.hydefront_version' => '1.0.0']);
+        $service = new AssetService();
+        $this->assertEquals('1.0.0', $service->version());
+    }
+
     public function test_cdn_path_constructor_returns_cdn_uri()
     {
         $service = new AssetService();

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,13 @@ public function test_version_method_returns_version_property_when_config_overrid`
`32`	`32`	`$this->assertEquals($service->version, $service->version());`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ public function test_version_can_be_set_in_config()`
	`36`	`+ {`
	`37`	`+ config(['hyde.hydefront_version' => '1.0.0']);`
	`38`	`+ $service = new AssetService();`
	`39`	`+ $this->assertEquals('1.0.0', $service->version());`
	`40`	`+ }`
	`41`	`+`
`35`	`42`	`public function test_cdn_path_constructor_returns_cdn_uri()`
`36`	`43`	`{`
`37`	`44`	`$service = new AssetService();`