Merge pull request #1118 from hydephp/update-test-to-account-for-time-drift

emmadesilva · web-flow · commit debb34f4e0cb · 2023-02-26T13:13:59.000+01:00
Update test to account for time drift
diff --git a/packages/framework/tests/Feature/TracksExecutionTimeTest.php b/packages/framework/tests/Feature/TracksExecutionTimeTest.php
@@ -21,7 +21,8 @@ public function test_startClock()
 
         $this->assertTrue($class->isset('timeStart'));
         $this->assertIsFloat($class->timeStart);
-        $this->assertSame(round(microtime(true)), round($class->timeStart));
+        // Assert that the difference between the two is less than 1 second to account for time drift (causes 1/10 000 tests to fail)
+        $this->assertLessThan(1, abs((microtime(true)) - ($class->timeStart)));
     }
 
     public function test_stopClock()

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@ public function test_startClock()`
`21`	`21`
`22`	`22`	`$this->assertTrue($class->isset('timeStart'));`
`23`	`23`	`$this->assertIsFloat($class->timeStart);`
`24`		`- $this->assertSame(round(microtime(true)), round($class->timeStart));`
	`24`	`+ // Assert that the difference between the two is less than 1 second to account for time drift (causes 1/10 000 tests to fail)`
	`25`	`+ $this->assertLessThan(1, abs((microtime(true)) - ($class->timeStart)));`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`public function test_stopClock()`