Merge pull request #1867 from hydephp/serve-command-test

emmadesilva · web-flow · commit d69bd8fb2a4c · 2024-07-17T15:56:48.000+02:00
Refactor the serve command and add more unit tests for it
diff --git a/packages/framework/src/Console/Commands/ServeCommand.php b/packages/framework/src/Console/Commands/ServeCommand.php
@@ -146,12 +146,7 @@ protected function checkArgvForOption(string $name): ?string
 
     protected function openInBrowser(string $path = '/'): void
     {
-        $binary = match (PHP_OS_FAMILY) {
-            'Windows' => 'start',
-            'Darwin' => 'open',
-            'Linux' => 'xdg-open',
-            default => null
-        };
+        $binary = $this->getOpenCommand(PHP_OS_FAMILY);
 
         $command = sprintf('%s http://%s:%d', $binary, $this->getHostSelection(), $this->getPortSelection());
         $command = rtrim("$command/$path", '/');
@@ -164,4 +159,14 @@ protected function openInBrowser(string $path = '/'): void
             $this->newLine();
         }
     }
+
+    protected function getOpenCommand(string $osFamily): ?string
+    {
+        return match ($osFamily) {
+            'Windows' => 'start',
+            'Darwin' => 'open',
+            'Linux' => 'xdg-open',
+            default => null
+        };
+    }
 }
diff --git a/packages/framework/tests/Unit/ServeCommandOptionsUnitTest.php b/packages/framework/tests/Unit/ServeCommandOptionsUnitTest.php
@@ -319,6 +319,26 @@ public function testOpenInBrowserThatFails()
         $command->openInBrowser();
     }
 
+    public function testGetOpenCommandForWindows()
+    {
+        $this->assertSame('start', $this->getMock()->getOpenCommand('Windows'));
+    }
+
+    public function testGetOpenCommandForDarwin()
+    {
+        $this->assertSame('open', $this->getMock()->getOpenCommand('Darwin'));
+    }
+
+    public function testGetOpenCommandForLinux()
+    {
+        $this->assertSame('xdg-open', $this->getMock()->getOpenCommand('Linux'));
+    }
+
+    public function testGetOpenCommandForUnknownOS()
+    {
+        $this->assertNull($this->getMock()->getOpenCommand('UnknownOS'));
+    }
+
     protected function getTestRunnerBinary(): string
     {
         return match (PHP_OS_FAMILY) {
@@ -388,6 +408,11 @@ public function option($key = null)
     {
         return $this->input->getOption($key);
     }
+
+    public function getOpenCommand(string $osFamily): ?string
+    {
+        return parent::getOpenCommand($osFamily);
+    }
 }
 
 class InputMock
