Merge pull request #862 from hydephp/unwrap-invokable-action-class

emmadesilva · web-flow · commit b815cae7df85 · 2023-01-22T18:58:38.000+01:00
Deprecate base class InvokableAction
diff --git a/packages/framework/src/Framework/Concerns/InvokableAction.php b/packages/framework/src/Framework/Concerns/InvokableAction.php
@@ -4,15 +4,20 @@
 
 namespace Hyde\Framework\Concerns;
 
+use JetBrains\PhpStorm\Deprecated;
+
 /**
  * Base class for invokable actions. Provides a helper to invoke the action statically.
  *
+ * @deprecated None of these child classes are ever used invokably used.
+ *             A better alternative is to simply use a static `handle` method as that offers full type and IDE support.
  * @see \Hyde\Framework\Testing\Feature\InvokableActionTest
  */
 abstract class InvokableAction
 {
     abstract public function __invoke(): mixed;
 
+    #[Deprecated(replacement: '%class%::handle(%parametersList%)')]
     public static function call(mixed ...$args): mixed
     {
         return (new static(...$args))->__invoke();

Original file line number	Diff line number	Diff line change
`@@ -4,15 +4,20 @@`
`4`	`4`
`5`	`5`	`namespace Hyde\Framework\Concerns;`
`6`	`6`
	`7`	`+use JetBrains\PhpStorm\Deprecated;`
	`8`	`+`
`7`	`9`	`/**`
`8`	`10`	`* Base class for invokable actions. Provides a helper to invoke the action statically.`
`9`	`11`	`*`
	`12`	`+ * @deprecated None of these child classes are ever used invokably used.`
	`13`	+ * A better alternative is to simply use a static `handle` method as that offers full type and IDE support.
`10`	`14`	`* @see \Hyde\Framework\Testing\Feature\InvokableActionTest`
`11`	`15`	`*/`
`12`	`16`	`abstract class InvokableAction`
`13`	`17`	`{`
`14`	`18`	`abstract public function __invoke(): mixed;`
`15`	`19`
	`20`	`+ #[Deprecated(replacement: '%class%::handle(%parametersList%)')]`
`16`	`21`	`public static function call(mixed ...$args): mixed`
`17`	`22`	`{`
`18`	`23`	`return (new static(...$args))->__invoke();`