Merge pull request #1257 from hydephp/fix-bug-where-post-view-is-not-using-proper-route-keys

emmadesilva · web-flow · commit aadbf6ca6c52 · 2023-03-12T20:16:58.000+01:00
Bugfixes: Blog post view uses legacy non-dynamic path information for metadata
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -24,7 +24,7 @@ This serves two purposes:
 - Removed `RenderData:.getCurrentRoute` method deprecated in v1.0.0-RC.2
 
 ### Fixed
-- for any bug fixes.
+- Fixed the blog post article view where metadata assembly used legacy hard-coded paths instead of dynamic path information.
 
 ### Security
 - in case of vulnerabilities.
diff --git a/packages/framework/resources/views/components/post/article.blade.php b/packages/framework/resources/views/components/post/article.blade.php
@@ -1,9 +1,9 @@
-<article aria-label="Article" id="{{ Hyde::url("posts/$page->identifier", '') }}" itemscope
+<article aria-label="Article" id="{{ $page->identifier }}" itemscope
          itemtype="https://schema.org/Article"
     @class(['post-article mx-auto prose dark:prose-invert', 'torchlight-enabled' => Hyde\Facades\Features::hasTorchlight()])>
     <meta itemprop="identifier" content="{{ $page->identifier }}">
-    @if(Hyde::hasSiteUrl())
-        <meta itemprop="url" content="{{ Hyde::url('posts/' . $page->identifier) }}">
+    @isset($page->canonicalUrl)
+        <meta itemprop="url" content="{{ $page->canonicalUrl }}">
     @endif
 
     <header aria-label="Header section" role="doc-pageheader">
diff --git a/packages/framework/tests/Feature/MetadataViewTest.php b/packages/framework/tests/Feature/MetadataViewTest.php
@@ -149,7 +149,7 @@ public function test_metadata_tags_in_empty_markdown_post()
             '<meta property="og:url" content="http://localhost/posts/test.html">',
             '<meta property="og:type" content="article">',
             '<meta itemprop="identifier" content="test">',
-            '<meta itemprop="url" content="http://localhost/posts/test">',
+            '<meta itemprop="url" content="http://localhost/posts/test.html">',
         ]));
 
         $this->assertAllTagsWereCovered('posts/test', $assertions);
@@ -191,7 +191,7 @@ public function test_metadata_tags_in_markdown_post_with_flat_front_matter()
             '<meta property="og:article:published_time" content="2022-01-01T00:00:00+00:00">',
             '<meta property="og:image" content="../media/image.jpg">',
             '<meta itemprop="identifier" content="test">',
-            '<meta itemprop="url" content="http://localhost/posts/test">',
+            '<meta itemprop="url" content="http://localhost/posts/test.html">',
             '<meta itemprop="url" content="../media/image.jpg">',
             '<meta itemprop="contentUrl" content="../media/image.jpg">',
         ]));
