Use relative sitemap links when site URL is for localhost

emmadesilva · emmadesilva · commit 84d96f75f613 · 2023-11-27T16:35:52.000+01:00
diff --git a/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php b/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php
@@ -22,6 +22,7 @@
 use function in_array;
 use function date;
 use function time;
+use function str_starts_with;
 
 /**
  * @see https://www.sitemaps.org/protocol.html
@@ -109,7 +110,7 @@ protected function resolveRouteLink(Route $route): string
     {
         $baseUrl = Config::getNullableString('hyde.url');
 
-        $canUseQualifiedUrl = filled($baseUrl);
+        $canUseQualifiedUrl = filled($baseUrl) && ! str_starts_with($baseUrl, 'http://localhost');
 
         if ($canUseQualifiedUrl) {
             return Hyde::url($route->getOutputPath());
diff --git a/packages/framework/tests/Feature/Services/SitemapServiceTest.php b/packages/framework/tests/Feature/Services/SitemapServiceTest.php
@@ -169,4 +169,15 @@ public function testLinksFallbackToRelativeLinksWhenASiteUrlIsNotSet()
         $this->assertEquals('404.html', $service->getXmlElement()->url[0]->loc);
         $this->assertEquals('index.html', $service->getXmlElement()->url[1]->loc);
     }
+
+    public function testLinksFallbackToRelativeLinksWhenSiteUrlIsLocalhost()
+    {
+        config(['hyde.url' => 'http://localhost']);
+
+        $service = new SitemapGenerator();
+        $service->generate();
+
+        $this->assertEquals('404.html', $service->getXmlElement()->url[0]->loc);
+        $this->assertEquals('index.html', $service->getXmlElement()->url[1]->loc);
+    }
 }
