Merge pull request #1397 from hydephp/publications-command-cleanup

emmadesilva · web-flow · commit 6a413a8b0e83 · 2023-10-27T18:22:11.000+02:00
Break down complex command class helper method
diff --git a/packages/publications/src/Commands/ValidatePublicationTypesCommand.php b/packages/publications/src/Commands/ValidatePublicationTypesCommand.php
@@ -89,24 +89,15 @@ protected function displayResults(): void
             if (empty($schemaErrors)) {
                 $this->line('<info>  No top-level schema errors found</info>');
             } else {
-                $this->line(sprintf('  <fg=red>Found %s top-level schema errors:</>', count($schemaErrors)));
-                foreach ($schemaErrors as $error) {
-                    $this->line(sprintf('    <fg=red>%s</> <comment>%s</comment>', self::CROSS_MARK, $error));
-                }
+                $this->displayTopLevelSchemaErrors($schemaErrors);
             }
 
             $schemaFields = $errors['fields'];
             if (empty(array_filter($schemaFields))) {
                 $this->line('<info>  No field-level schema errors found</info>');
             } else {
                 $this->newLine();
-                $this->line(sprintf('  <fg=red>Found errors in %s field definitions:</>', count($schemaFields)));
-                foreach ($schemaFields as $fieldNumber => $fieldErrors) {
-                    $this->line(sprintf('    <fg=cyan>Field #%s:</>', $fieldNumber + 1));
-                    foreach ($fieldErrors as $error) {
-                        $this->line(sprintf('      <fg=red>%s</> <comment>%s</comment>', self::CROSS_MARK, $error));
-                    }
-                }
+                $this->displayFieldDefinitionErrors($schemaFields);
             }
 
             if (next($this->results)) {
@@ -115,6 +106,25 @@ protected function displayResults(): void
         }
     }
 
+    protected function displayTopLevelSchemaErrors(array $schemaErrors): void
+    {
+        $this->line(sprintf('  <fg=red>Found %s top-level schema errors:</>', count($schemaErrors)));
+        foreach ($schemaErrors as $error) {
+            $this->line(sprintf('    <fg=red>%s</> <comment>%s</comment>', self::CROSS_MARK, $error));
+        }
+    }
+
+    protected function displayFieldDefinitionErrors(array $schemaFields): void
+    {
+        $this->line(sprintf('  <fg=red>Found errors in %s field definitions:</>', count($schemaFields)));
+        foreach ($schemaFields as $fieldNumber => $fieldErrors) {
+            $this->line(sprintf('    <fg=cyan>Field #%s:</>', $fieldNumber + 1));
+            foreach ($fieldErrors as $error) {
+                $this->line(sprintf('      <fg=red>%s</> <comment>%s</comment>', self::CROSS_MARK, $error));
+            }
+        }
+    }
+
     protected function outputSummary($timeStart): void
     {
         $this->newLine();
