Merge pull request #934 from hydephp/display-different-message-for-dynamic-pages-in-route-list-command

emmadesilva · web-flow · commit 5f3b60fcaf4f · 2023-02-08T18:38:21.000+01:00
Display different message for dynamic pages in route list command
diff --git a/packages/framework/src/Console/Commands/RouteListCommand.php b/packages/framework/src/Console/Commands/RouteListCommand.php
@@ -6,6 +6,7 @@
 
 use Hyde\Console\Concerns\Command;
 use Hyde\Hyde;
+use Hyde\Pages\Contracts\DynamicPage;
 
 /**
  * Hyde command to display the list of site routes.
@@ -39,7 +40,7 @@ protected function getRoutes(): array
         foreach (Hyde::routes() as $route) {
             $routes[] = [
                 $this->formatPageType($route->getPageClass()),
-                $this->formatSourcePath($route->getSourcePath()),
+                $this->formatSourcePath($route->getSourcePath(), $route->getPageClass()),
                 $this->formatOutputPath($route->getOutputPath()),
                 $route->getRouteKey(),
             ];
@@ -53,8 +54,12 @@ protected function formatPageType(string $class): string
         return str_starts_with($class, 'Hyde') ? class_basename($class) : $class;
     }
 
-    protected function formatSourcePath(string $path): string
+    protected function formatSourcePath(string $path, string $class): string
     {
+        if (is_a($class, DynamicPage::class, true)) {
+            return '<fg=yellow>dynamic</>';
+        }
+
         return $this->clickablePathLink(static::createClickableFilepath(Hyde::path($path)), $path);
     }
 
diff --git a/packages/framework/tests/Feature/Commands/RouteListCommandTest.php b/packages/framework/tests/Feature/Commands/RouteListCommandTest.php
@@ -4,6 +4,9 @@
 
 namespace Hyde\Framework\Testing\Feature\Commands;
 
+use Hyde\Hyde;
+use Hyde\Pages\VirtualPage;
+use Hyde\Support\Models\Route;
 use Hyde\Testing\TestCase;
 
 /**
@@ -36,4 +39,31 @@ public function testClickableLinks()
         $this->artisan('route:list')
             ->assertExitCode(0);
     }
+
+    public function testWithDynamicPages()
+    {
+        Hyde::routes()->put('foo', new Route(new VirtualPage('foo')));
+
+        $this->artisan('route:list')
+            ->expectsTable(['Page Type', 'Source File', 'Output File', 'Route Key'], [
+                [
+                    'BladePage',
+                    '_pages/404.blade.php',
+                    '_site/404.html',
+                    '404',
+                ],
+                [
+                    'BladePage',
+                    '_pages/index.blade.php',
+                    '_site/index.html',
+                    'index',
+                ],
+                [
+                    'VirtualPage',
+                    '<fg=yellow>dynamic</>',
+                    '_site/foo.html',
+                    'foo',
+                ],
+            ])->assertExitCode(0);
+    }
 }
