Merge pull request #1417 from hydephp/code-quality

emmadesilva · web-flow · commit 5ad417a91a1e · 2023-10-29T15:11:51.000+01:00
Clean up test
diff --git a/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php b/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php
@@ -111,7 +111,7 @@ public function testRegisterTaskWithoutChildExtensionThrowsException()
     public function testRegisterTaskWithBaseClassThrowsException()
     {
         $this->expectException(TypeError::class);
-        $this->service->registerTask(InstansiableTestBuildTask::class);
+        $this->service->registerTask(InstantiableTestBuildTask::class);
     }
 
     public function testRegisterTaskWithAlreadyRegisteredTask()
@@ -293,9 +293,9 @@ public function testServiceFindsTasksInAppDirectory()
         $filesystem = Mockery::mock(Filesystem::class, [$kernel])->makePartial()
             ->shouldReceive('smartGlob')->once()
             ->with('app/Actions/*BuildTask.php', 0)
-            ->andReturn(collect([/** TODO */]))->getMock();
+            ->andReturn(collect())->getMock();
 
-        // Inject mock into Kernel (No better way to do this at the moment)
+        // Inject mock into Kernel
         (new ReflectionClass($kernel))->getProperty('filesystem')->setValue($kernel, $filesystem);
 
         $this->createService();
@@ -322,7 +322,7 @@ protected function verifyMockeryExpectations(): void
     }
 }
 
-class InstansiableTestBuildTask extends BuildTask
+class InstantiableTestBuildTask extends BuildTask
 {
     public function handle(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public function testRegisterTaskWithoutChildExtensionThrowsException()`
`111`	`111`	`public function testRegisterTaskWithBaseClassThrowsException()`
`112`	`112`	`{`
`113`	`113`	`$this->expectException(TypeError::class);`
`114`		`- $this->service->registerTask(InstansiableTestBuildTask::class);`
	`114`	`+ $this->service->registerTask(InstantiableTestBuildTask::class);`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`public function testRegisterTaskWithAlreadyRegisteredTask()`
`@@ -293,9 +293,9 @@ public function testServiceFindsTasksInAppDirectory()`
`293`	`293`	`$filesystem = Mockery::mock(Filesystem::class, [$kernel])->makePartial()`
`294`	`294`	`->shouldReceive('smartGlob')->once()`
`295`	`295`	`->with('app/Actions/*BuildTask.php', 0)`
`296`		`- ->andReturn(collect([/** TODO */]))->getMock();`
	`296`	`+ ->andReturn(collect())->getMock();`
`297`	`297`
`298`		`- // Inject mock into Kernel (No better way to do this at the moment)`
	`298`	`+ // Inject mock into Kernel`
`299`	`299`	`(new ReflectionClass($kernel))->getProperty('filesystem')->setValue($kernel, $filesystem);`
`300`	`300`
`301`	`301`	`$this->createService();`
`@@ -322,7 +322,7 @@ protected function verifyMockeryExpectations(): void`
`322`	`322`	`}`
`323`	`323`	`}`
`324`	`324`
`325`		`-class InstansiableTestBuildTask extends BuildTask`
	`325`	`+class InstantiableTestBuildTask extends BuildTask`
`326`	`326`	`{`
`327`	`327`	`public function handle(): void`
`328`	`328`	`{`