Merge pull request #859 from hydephp/narrow-down-mixed-return-types

emmadesilva · web-flow · commit 588226be9783 · 2023-01-22T15:14:28.000+01:00
Narrow down mixed return types
diff --git a/packages/framework/src/Console/Commands/MakePostCommand.php b/packages/framework/src/Console/Commands/MakePostCommand.php
@@ -43,7 +43,7 @@ public function handle(): int
         return $this->createPostFile($creator);
     }
 
-    protected function getTitle(): mixed
+    protected function getTitle(): string
     {
         $this->line($this->argument('title')
                 ? '<info>Selected title: '.$this->argument('title')."</info>\n"
diff --git a/packages/framework/src/Foundation/Application.php b/packages/framework/src/Foundation/Application.php
@@ -8,7 +8,7 @@
 use Illuminate\Foundation\PackageManifest;
 
 /**
- * @property mixed $app
+ * @property self $app
  */
 class Application extends \LaravelZero\Framework\Application
 {
diff --git a/packages/framework/src/Framework/Concerns/InteractsWithFrontMatter.php b/packages/framework/src/Framework/Concerns/InteractsWithFrontMatter.php
@@ -31,8 +31,6 @@ public function data(string $key = null, mixed $default = null): mixed
      * Get the front matter object, or a value from within.
      *
      * @return \Hyde\Markdown\Models\FrontMatter|mixed
-     *
-     * @todo Narrow down mixed return type to static + only types that can be in front matter.
      */
     public function matter(string $key = null, mixed $default = null): mixed
     {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function handle(): int`
`43`	`43`	`return $this->createPostFile($creator);`
`44`	`44`	`}`
`45`	`45`
`46`		`- protected function getTitle(): mixed`
	`46`	`+ protected function getTitle(): string`
`47`	`47`	`{`
`48`	`48`	`$this->line($this->argument('title')`
`49`	`49`	`? '<info>Selected title: '.$this->argument('title')."</info>\n"`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Illuminate\Foundation\PackageManifest;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * @property mixed $app`
	`11`	`+ * @property self $app`
`12`	`12`	`*/`
`13`	`13`	`class Application extends \LaravelZero\Framework\Application`
`14`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ public function data(string $key = null, mixed $default = null): mixed`
`31`	`31`	`* Get the front matter object, or a value from within.`
`32`	`32`	`*`
`33`	`33`	`* @return \Hyde\Markdown\Models\FrontMatter\|mixed`
`34`		`- *`
`35`		`- * @todo Narrow down mixed return type to static + only types that can be in front matter.`
`36`	`34`	`*/`
`37`	`35`	`public function matter(string $key = null, mixed $default = null): mixed`
`38`	`36`	`{`