Merge pull request #1272 from hydephp/add-missing-version-prefix-for-meta-version

emmadesilva · web-flow · commit 573f1576f903 · 2023-03-14T10:36:06.000+01:00
Prefix version for default meta generator value
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -23,7 +23,7 @@ This serves two purposes:
 - Removed default values from Hyde facade method annotations
 
 ### Fixed
-- for any bug fixes.
+- Added missing version prefix to default generator meta tag value. https://github.com/hydephp/develop/pull/1272
 
 ### Security
 - in case of vulnerabilities.
diff --git a/config/hyde.php b/config/hyde.php
@@ -220,7 +220,7 @@
         // Meta::name('twitter:creator', '@HydeFramework'),
         // Meta::name('description', 'My Hyde Blog'),
         // Meta::name('keywords', 'Static Sites, Blogs, Documentation'),
-        Meta::name('generator', 'HydePHP '.Hyde\Hyde::version()),
+        Meta::name('generator', 'HydePHP v'.Hyde\Hyde::version()),
         Meta::property('site_name', env('SITE_NAME', 'HydePHP')),
     ],
 
diff --git a/packages/framework/config/hyde.php b/packages/framework/config/hyde.php
@@ -220,7 +220,7 @@
         // Meta::name('twitter:creator', '@HydeFramework'),
         // Meta::name('description', 'My Hyde Blog'),
         // Meta::name('keywords', 'Static Sites, Blogs, Documentation'),
-        Meta::name('generator', 'HydePHP '.Hyde\Hyde::version()),
+        Meta::name('generator', 'HydePHP v'.Hyde\Hyde::version()),
         Meta::property('site_name', env('SITE_NAME', 'HydePHP')),
     ],
 
diff --git a/packages/framework/tests/Feature/MetadataViewTest.php b/packages/framework/tests/Feature/MetadataViewTest.php
@@ -80,7 +80,7 @@ protected function getDefaultTags(): array
             '<meta name="viewport" content="width=device-width, initial-scale=1">',
             '<meta id="meta-color-scheme" name="color-scheme" content="light">',
             '<link rel="sitemap" href="http://localhost/sitemap.xml" type="application/xml" title="Sitemap">',
-            '<meta name="generator" content="HydePHP '.HydeKernel::VERSION.'">',
+            '<meta name="generator" content="HydePHP v'.HydeKernel::VERSION.'">',
             '<meta property="og:site_name" content="HydePHP">',
         ];
     }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ protected function getDefaultTags(): array`
`80`	`80`	`'<meta name="viewport" content="width=device-width, initial-scale=1">',`
`81`	`81`	`'<meta id="meta-color-scheme" name="color-scheme" content="light">',`
`82`	`82`	`'<link rel="sitemap" href="http://localhost/sitemap.xml" type="application/xml" title="Sitemap">',`
`83`		`- '<meta name="generator" content="HydePHP '.HydeKernel::VERSION.'">',`
	`83`	`+ '<meta name="generator" content="HydePHP v'.HydeKernel::VERSION.'">',`
`84`	`84`	`'<meta property="og:site_name" content="HydePHP">',`
`85`	`85`	`];`
`86`	`86`	`}`