Merge pull request #759 from hydephp/update-FileNotFoundException

emmadesilva · web-flow · commit 44d9e14535ec · 2022-12-15T11:48:13.000+01:00
Wrap the file path in brackets for the FileNotFoundException
diff --git a/packages/framework/src/Framework/Exceptions/FileNotFoundException.php b/packages/framework/src/Framework/Exceptions/FileNotFoundException.php
@@ -16,7 +16,7 @@ class FileNotFoundException extends Exception
 
     public function __construct(?string $path = null, ?string $message = null)
     {
-        $this->message = $message ?? ($path ? "File $path not found." : $this->message);
+        $this->message = $message ?? ($path ? "File [$path] not found." : $this->message);
 
         parent::__construct($this->message, $this->code);
     }
diff --git a/packages/framework/tests/Feature/Actions/AnonymousViewCompilerTest.php b/packages/framework/tests/Feature/Actions/AnonymousViewCompilerTest.php
@@ -30,7 +30,7 @@ public function testCanCompileBladeFileWithData()
     public function testWithMissingView()
     {
         $this->expectException(FileNotFoundException::class);
-        $this->expectExceptionMessage('File foo.blade.php not found.');
+        $this->expectExceptionMessage('File [foo.blade.php] not found.');
 
         AnonymousViewCompiler::call('foo.blade.php');
     }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class FileNotFoundException extends Exception`
`16`	`16`
`17`	`17`	`public function __construct(?string $path = null, ?string $message = null)`
`18`	`18`	`{`
`19`		`- $this->message = $message ?? ($path ? "File $path not found." : $this->message);`
	`19`	`+ $this->message = $message ?? ($path ? "File [$path] not found." : $this->message);`
`20`	`20`
`21`	`21`	`parent::__construct($this->message, $this->code);`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function testCanCompileBladeFileWithData()`
`30`	`30`	`public function testWithMissingView()`
`31`	`31`	`{`
`32`	`32`	`$this->expectException(FileNotFoundException::class);`
`33`		`- $this->expectExceptionMessage('File foo.blade.php not found.');`
	`33`	`+ $this->expectExceptionMessage('File [foo.blade.php] not found.');`
`34`	`34`
`35`	`35`	`AnonymousViewCompiler::call('foo.blade.php');`
`36`	`36`	`}`