Merge pull request #2135 from hydephp/fix-serve-command-not-handling-project-path-with-spaces

emmadesilva · web-flow · commit 367e266c6c5d · 2025-04-20T14:51:33.000+02:00
Fix serve command not handling project path with spaces
diff --git a/packages/framework/src/Console/Commands/ServeCommand.php b/packages/framework/src/Console/Commands/ServeCommand.php
@@ -54,7 +54,7 @@ public function safeHandle(): int
         $this->runServerProcess(sprintf('php -S %s:%d %s',
             $this->getHostSelection(),
             $this->getPortSelection(),
-            $this->getExecutablePath()
+            escapeshellarg($this->getExecutablePath()),
         ));
 
         return Command::SUCCESS;
diff --git a/packages/framework/tests/Feature/Commands/ServeCommandTest.php b/packages/framework/tests/Feature/Commands/ServeCommandTest.php
@@ -176,6 +176,6 @@ public function testWithFancyOutput()
 
     protected function binaryPath(): string
     {
-        return Hyde::path('vendor/hyde/realtime-compiler/bin/server.php');
+        return escapeshellarg(Hyde::path('vendor/hyde/realtime-compiler/bin/server.php'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,6 @@ public function testWithFancyOutput()`
`176`	`176`
`177`	`177`	`protected function binaryPath(): string`
`178`	`178`	`{`
`179`		`- return Hyde::path('vendor/hyde/realtime-compiler/bin/server.php');`
	`179`	`+ return escapeshellarg(Hyde::path('vendor/hyde/realtime-compiler/bin/server.php'));`
`180`	`180`	`}`
`181`	`181`	`}`