Merge pull request #1609 from hydephp/refactor-and-improve-testing-internals

emmadesilva · web-flow · commit 343c6b78c9c0 · 2024-03-14T21:31:38.000+01:00
Internal: Improve and refactor testing helpers
diff --git a/packages/testing/src/InteractsWithPages.php b/packages/testing/src/InteractsWithPages.php
@@ -4,26 +4,27 @@
 
 namespace Hyde\Testing;
 
+use Hyde\Pages\InMemoryPage;
 use Hyde\Pages\Concerns\HydePage;
-use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Facades\Render;
 use Hyde\Support\Models\Route;
 
 trait InteractsWithPages
 {
     protected function mockRoute(?Route $route = null): void
     {
-        Render::share('route', $route ?? (new Route(new MarkdownPage())));
+        Render::share('route', $route ?? (new Route(new InMemoryPage())));
     }
 
     protected function mockPage(?HydePage $page = null, ?string $currentPage = null): void
     {
-        Render::share('page', $page ?? new MarkdownPage());
-        Render::share('routeKey', $currentPage ?? 'PHPUnit');
+        Render::share('page', $page ?? new InMemoryPage());
+        Render::share('routeKey', $currentPage ?? 'foo');
     }
 
     protected function mockCurrentPage(string $currentPage): void
     {
         Render::share('routeKey', $currentPage);
+        Render::share('route', new Route(new InMemoryPage($currentPage)));
     }
 }
diff --git a/packages/testing/src/Support/TestView.php b/packages/testing/src/Support/TestView.php
@@ -4,6 +4,9 @@
 
 namespace Hyde\Testing\Support;
 
+use Hyde\Hyde;
+use Illuminate\Support\Str;
+use JetBrains\PhpStorm\NoReturn;
 use Illuminate\Testing\Assert as PHPUnit;
 
 class TestView extends \Illuminate\Testing\TestView
@@ -41,7 +44,33 @@ public function assertSeeHtmlIgnoringFormatting(string $value): static
      */
     public function assertAttributeIs(string $attributeName, string $expectedValue): static
     {
-        PHPUnit::assertStringContainsString($attributeName.'="'.$expectedValue.'"', $this->rendered);
+        static::assertHasAttribute($attributeName);
+
+        PHPUnit::assertStringContainsString($attributeName.'="'.$expectedValue.'"', $this->rendered, "The attribute '$attributeName' with value '$expectedValue' was not found.");
+
+        return $this;
+    }
+
+    /**
+     * Assert that the HTML attribute is present within the view.
+     *
+     * @return $this
+     */
+    public function assertHasAttribute(string $attributeName): static
+    {
+        PHPUnit::assertStringContainsString($attributeName.'="', $this->rendered, "The attribute '$attributeName' was not found.");
+
+        return $this;
+    }
+
+    /**
+     * Assert that the HTML attribute is not present within the view.
+     *
+     * @return $this
+     */
+    public function assertDoesNotHaveAttribute(string $attributeName): static
+    {
+        PHPUnit::assertStringNotContainsString($attributeName.'="', $this->rendered, "The attribute '$attributeName' was found.");
 
         return $this;
     }
@@ -58,6 +87,17 @@ public function assertTextIs(string $value): static
         return $this;
     }
 
+    #[NoReturn]
+    public function dd(bool $writeHtml = true): void
+    {
+        if ($writeHtml) {
+            $viewName = Str::after(Str::after(basename(class_basename($this->view->getName())), '.'), '.');
+            file_put_contents(Hyde::path(Str::kebab($viewName.'.html')), $this->rendered);
+        }
+
+        exit(trim($this->rendered)."\n\n");
+    }
+
     protected function trimNewlinesAndIndentation(string $value): string
     {
         return str_replace(['    ', "\t", "\n", "\r"], '', $value);

Original file line number	Diff line number	Diff line change
`@@ -4,26 +4,27 @@`
`4`	`4`
`5`	`5`	`namespace Hyde\Testing;`
`6`	`6`
	`7`	`+use Hyde\Pages\InMemoryPage;`
`7`	`8`	`use Hyde\Pages\Concerns\HydePage;`
`8`		`-use Hyde\Pages\MarkdownPage;`
`9`	`9`	`use Hyde\Support\Facades\Render;`
`10`	`10`	`use Hyde\Support\Models\Route;`
`11`	`11`
`12`	`12`	`trait InteractsWithPages`
`13`	`13`	`{`
`14`	`14`	`protected function mockRoute(?Route $route = null): void`
`15`	`15`	`{`
`16`		`- Render::share('route', $route ?? (new Route(new MarkdownPage())));`
	`16`	`+ Render::share('route', $route ?? (new Route(new InMemoryPage())));`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`protected function mockPage(?HydePage $page = null, ?string $currentPage = null): void`
`20`	`20`	`{`
`21`		`- Render::share('page', $page ?? new MarkdownPage());`
`22`		`- Render::share('routeKey', $currentPage ?? 'PHPUnit');`
	`21`	`+ Render::share('page', $page ?? new InMemoryPage());`
	`22`	`+ Render::share('routeKey', $currentPage ?? 'foo');`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`protected function mockCurrentPage(string $currentPage): void`
`26`	`26`	`{`
`27`	`27`	`Render::share('routeKey', $currentPage);`
	`28`	`+ Render::share('route', new Route(new InMemoryPage($currentPage)));`
`28`	`29`	`}`
`29`	`30`	`}`