Skip to content

Commit 29241c6

Browse files
emmadesilvaemmadesilva
authored
Merge pull request #1329 from hydephp/bump-hydefront-to-v3.3
Update HydeFront to v3.3
2 parents f0912d1 + f93dc8b commit 29241c6

File tree

13 files changed

+25
-24
lines changed

13 files changed

+25
-24
lines changed

‎.github/workflows/continuous-integration.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ jobs:
107107
run: npm run prod
108108

109109
- name: Add copyright text to compiled file
110-
# add '/*! HydeFront v3.0.0 | MIT License | https://hydephp.com*/' to the top of the packages/hydefront/dist/hyde.css file
111-
run: sed -i '1s/^/\/\*! HydeFront v3.0.0 | MIT License | https:\/\/hydephp.com\*\/\n/' packages/hydefront/dist/hyde.css
110+
# add '/*! HydeFront v3.3.0 | MIT License | https://hydephp.com*/' to the top of the packages/hydefront/dist/hyde.css file
111+
run: sed -i '1s/^/\/\*! HydeFront v3.3.0 | MIT License | https:\/\/hydephp.com\*\/\n/' packages/hydefront/dist/hyde.css
112112

113113
- name: Upload artifacts
114114
uses: actions/upload-artifact@v1

‎RELEASE_NOTES.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ This release is the first since the official release of HydePHP 1.0.0. It contai
1111
- Updated discovery exception message to include the causing exception message in https://github.com/hydephp/develop/pull/1305
1212
- Cleaned up `PageDataFactory`, `NavigationDataFactory`, and `BlogPostDataFactory` internals for better type safety in https://github.com/hydephp/develop/pull/1312
1313
- Refactored internals to use the `View` facade over the `view` function for better type safety in https://github.com/hydephp/develop/pull/1310
14+
- Updated to HydeFront v3.3.0 in https://github.com/hydephp/develop/pull/1329
1415

1516
### Deprecated
1617
- for soon-to-be removed features.

‎_media/app.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package-lock.json‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"devDependencies": {
3333
"@tailwindcss/typography": "^0.5.2",
3434
"autoprefixer": "^10.4.5",
35-
"hydefront": "^3.2.0",
35+
"hydefront": "^3.3.0",
3636
"laravel-mix": "^6.0.49",
3737
"postcss": "^8.4.13",
3838
"prettier": "2.6.0",

‎packages/framework/src/Framework/Services/AssetService.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
class AssetService
3232
{
3333
/** @var string The default HydeFront SemVer tag to load. This constant is set to match the styles used for the installed framework version. */
34-
final public const HYDEFRONT_VERSION = 'v3.0';
34+
final public const HYDEFRONT_VERSION = 'v3.3';
3535

3636
/** @var string The default HydeFront CDN path pattern. The Blade-style placeholders are replaced with the proper values. */
3737
final public const HYDEFRONT_CDN_URL = 'https://cdn.jsdelivr.net/npm/hydefront@{{ $version }}/dist/{{ $file }}';

‎packages/framework/tests/Unit/AssetServiceUnitTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ protected function setUp(): void
2323

2424
public function testVersionStringConstant()
2525
{
26-
$this->assertSame('v3.0', AssetService::HYDEFRONT_VERSION);
26+
$this->assertSame('v3.3', AssetService::HYDEFRONT_VERSION);
2727
}
2828

2929
public function testServiceHasVersionString()
@@ -56,7 +56,7 @@ public function testCanSetCustomCdnUrlInConfig()
5656
public function testCanUseCustomCdnUrlWithVersion()
5757
{
5858
self::mockConfig(['hyde.hydefront_url' => '{{ $version }}']);
59-
$this->assertSame('v3.0', (new AssetService())->cdnLink(''));
59+
$this->assertSame('v3.3', (new AssetService())->cdnLink(''));
6060
}
6161

6262
public function testCanUseCustomCdnUrlWithFile()
@@ -68,7 +68,7 @@ public function testCanUseCustomCdnUrlWithFile()
6868
public function testCanUseCustomCdnUrlWithVersionAndFile()
6969
{
7070
self::mockConfig(['hyde.hydefront_url' => '{{ $version }}/{{ $file }}']);
71-
$this->assertSame('v3.0/styles.css', (new AssetService())->cdnLink('styles.css'));
71+
$this->assertSame('v3.3/styles.css', (new AssetService())->cdnLink('styles.css'));
7272
}
7373

7474
public function testCanUseCustomCdnUrlWithCustomVersion()
@@ -83,7 +83,7 @@ public function testCanUseCustomCdnUrlWithCustomVersion()
8383
public function testCdnLinkHelper()
8484
{
8585
$this->assertSame(
86-
'https://cdn.jsdelivr.net/npm/hydefront@v3.0/dist/styles.css',
86+
'https://cdn.jsdelivr.net/npm/hydefront@v3.3/dist/styles.css',
8787
(new AssetService())->cdnLink('styles.css')
8888
);
8989
}

‎packages/hydefront/.github/workflows/node.js.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ jobs:
2727
run: npm run prod
2828

2929
- name: Add copyright text to compiled file
30-
# add '/*! HydeFront v3.0.0 | MIT License | https://hydephp.com*/' to the top of the dist/hyde.css file
31-
run: sed -i '1s/^/\/\*! HydeFront v3.0.0 | MIT License | https:\/\/hydephp.com\*\/\n/' dist/hyde.css
30+
# add '/*! HydeFront v3.3.0 | MIT License | https://hydephp.com*/' to the top of the dist/hyde.css file
31+
run: sed -i '1s/^/\/\*! HydeFront v3.3.0 | MIT License | https:\/\/hydephp.com\*\/\n/' dist/hyde.css
3232

3333
- name: Upload artifacts
3434
uses: actions/upload-artifact@v1

‎packages/hydefront/dist/app.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/hydefront/dist/hyde.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)