Merge pull request #1110 from hydephp/update-dynamic-title-generation-for-index-pages-to-use-the-titled-parent-basename

emmadesilva · web-flow · commit 1f8afc42bfc3 · 2023-02-24T16:25:24.000+01:00
Update dynamic title generation for index pages to use parent basename
diff --git a/packages/framework/src/Framework/Factories/HydePageDataFactory.php b/packages/framework/src/Framework/Factories/HydePageDataFactory.php
@@ -78,6 +78,7 @@ private function findTitleForPage(): string
     {
         return $this->matter('title')
             ?? $this->findTitleFromMarkdownHeadings()
+            ?? $this->findTitleFromParentIdentifier()
             ?? Hyde::makeTitle(basename($this->identifier));
     }
 
@@ -94,6 +95,15 @@ private function findTitleFromMarkdownHeadings(): ?string
         return null;
     }
 
+    private function findTitleFromParentIdentifier(): ?string
+    {
+        if (str_contains($this->identifier, '/') && str_ends_with($this->identifier, '/index')) {
+            return Hyde::makeTitle(basename(dirname($this->identifier)));
+        }
+
+        return null;
+    }
+
     private function getCanonicalUrl(): ?string
     {
         if (! empty($this->matter('canonicalUrl'))) {
diff --git a/packages/framework/tests/Unit/HydePageDataFactoryTest.php b/packages/framework/tests/Unit/HydePageDataFactoryTest.php
@@ -66,6 +66,16 @@ public function testTitleFallsBackToIdentifierBasename()
         $this->assertSame('Bar', $this->factoryFromPage(new MarkdownPage('foo/bar'))->toArray()['title']);
     }
 
+    public function testIndexPageTitlesCanBeCreatedFromParentIdentifierBasename()
+    {
+        $this->assertSame('Foo', $this->factoryFromPage(new MarkdownPage('foo/index'))->toArray()['title']);
+    }
+
+    public function testIndexPageTitlesCanBeCreatedFromNestedParentIdentifierBasename()
+    {
+        $this->assertSame('Bar', $this->factoryFromPage(new MarkdownPage('foo/bar/index'))->toArray()['title']);
+    }
+
     public function testCanCreateCanonicalUrlUsingBaseUrlFromConfig()
     {
         self::mockConfig(['hyde' => [

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ private function findTitleForPage(): string`
`78`	`78`	`{`
`79`	`79`	`return $this->matter('title')`
`80`	`80`	`?? $this->findTitleFromMarkdownHeadings()`
	`81`	`+ ?? $this->findTitleFromParentIdentifier()`
`81`	`82`	`?? Hyde::makeTitle(basename($this->identifier));`
`82`	`83`	`}`
`83`	`84`
`@@ -94,6 +95,15 @@ private function findTitleFromMarkdownHeadings(): ?string`
`94`	`95`	`return null;`
`95`	`96`	`}`
`96`	`97`
	`98`	`+ private function findTitleFromParentIdentifier(): ?string`
	`99`	`+ {`
	`100`	`+ if (str_contains($this->identifier, '/') && str_ends_with($this->identifier, '/index')) {`
	`101`	`+ return Hyde::makeTitle(basename(dirname($this->identifier)));`
	`102`	`+ }`
	`103`	`+`
	`104`	`+ return null;`
	`105`	`+ }`
	`106`	`+`
`97`	`107`	`private function getCanonicalUrl(): ?string`
`98`	`108`	`{`
`99`	`109`	`if (! empty($this->matter('canonicalUrl'))) {`