Merge pull request #931 from hydephp/remove-stringable-from-project-file-class

emmadesilva · web-flow · commit 13bb1e54acc5 · 2023-02-08T15:06:11.000+01:00
ProjectFile and inheritors no longer implement Stringable interface
diff --git a/packages/framework/src/Support/Filesystem/ProjectFile.php b/packages/framework/src/Support/Filesystem/ProjectFile.php
@@ -10,14 +10,13 @@
 use Hyde\Support\Concerns\Serializable;
 use Hyde\Support\Contracts\SerializableContract;
 use function pathinfo;
-use Stringable;
 
 /**
  * Filesystem abstraction for a file stored in the project.
  *
  * @see \Hyde\Framework\Testing\Feature\Support\ProjectFileTest
  */
-abstract class ProjectFile implements SerializableContract, Stringable
+abstract class ProjectFile implements SerializableContract
 {
     use Serializable;
 
@@ -39,11 +38,6 @@ public function __construct(string $path)
         $this->path = Hyde::pathToRelative($path);
     }
 
-    public function __toString(): string
-    {
-        return $this->path;
-    }
-
     /**
      * @return array{name: string, path: string}
      */
diff --git a/packages/framework/tests/Feature/Support/MediaFileTest.php b/packages/framework/tests/Feature/Support/MediaFileTest.php
@@ -36,11 +36,6 @@ public function test_absolute_path_is_normalized_to_relative()
         $this->assertEquals('foo', MediaFile::make(Hyde::path('foo'))->path);
     }
 
-    public function test_to_string_returns_path()
-    {
-        $this->assertSame('foo', (string) MediaFile::make('foo'));
-    }
-
     public function test_get_name_returns_name_of_file()
     {
         $this->assertSame('foo.txt', MediaFile::make('foo.txt')->getName());
diff --git a/packages/framework/tests/Feature/Support/ProjectFileTest.php b/packages/framework/tests/Feature/Support/ProjectFileTest.php
@@ -35,11 +35,6 @@ public function test_absolute_path_is_normalized_to_relative()
         $this->assertEquals('foo', ProjectFileTestClass::make(Hyde::path('foo'))->path);
     }
 
-    public function test_to_string_returns_path()
-    {
-        $this->assertSame('foo', (string) ProjectFileTestClass::make('foo'));
-    }
-
     public function test_get_name_returns_name_of_file()
     {
         $this->assertSame('foo.txt', ProjectFileTestClass::make('foo.txt')->getName());
diff --git a/packages/framework/tests/Feature/Support/SourceFileTest.php b/packages/framework/tests/Feature/Support/SourceFileTest.php
@@ -54,11 +54,6 @@ public function test_absolute_path_is_normalized_to_relative()
         $this->assertEquals('foo', SourceFile::make(Hyde::path('foo'))->path);
     }
 
-    public function test_to_string_returns_path()
-    {
-        $this->assertSame('foo', (string) SourceFile::make('foo'));
-    }
-
     public function test_get_name_returns_name_of_file()
     {
         $this->assertSame('foo.txt', SourceFile::make('foo.txt')->getName());

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,6 @@ public function test_absolute_path_is_normalized_to_relative()`
`36`	`36`	`$this->assertEquals('foo', MediaFile::make(Hyde::path('foo'))->path);`
`37`	`37`	`}`
`38`	`38`
`39`		`- public function test_to_string_returns_path()`
`40`		`- {`
`41`		`- $this->assertSame('foo', (string) MediaFile::make('foo'));`
`42`		`- }`
`43`		`-`
`44`	`39`	`public function test_get_name_returns_name_of_file()`
`45`	`40`	`{`
`46`	`41`	`$this->assertSame('foo.txt', MediaFile::make('foo.txt')->getName());`
Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,6 @@ public function test_absolute_path_is_normalized_to_relative()`
`35`	`35`	`$this->assertEquals('foo', ProjectFileTestClass::make(Hyde::path('foo'))->path);`
`36`	`36`	`}`
`37`	`37`
`38`		`- public function test_to_string_returns_path()`
`39`		`- {`
`40`		`- $this->assertSame('foo', (string) ProjectFileTestClass::make('foo'));`
`41`		`- }`
`42`		`-`
`43`	`38`	`public function test_get_name_returns_name_of_file()`
`44`	`39`	`{`
`45`	`40`	`$this->assertSame('foo.txt', ProjectFileTestClass::make('foo.txt')->getName());`
Original file line number	Diff line number	Diff line change
`@@ -54,11 +54,6 @@ public function test_absolute_path_is_normalized_to_relative()`
`54`	`54`	`$this->assertEquals('foo', SourceFile::make(Hyde::path('foo'))->path);`
`55`	`55`	`}`
`56`	`56`
`57`		`- public function test_to_string_returns_path()`
`58`		`- {`
`59`		`- $this->assertSame('foo', (string) SourceFile::make('foo'));`
`60`		`- }`
`61`		`-`
`62`	`57`	`public function test_get_name_returns_name_of_file()`
`63`	`58`	`{`
`64`	`59`	`$this->assertSame('foo.txt', SourceFile::make('foo.txt')->getName());`