Merge pull request #1002 from hydephp/handle-deprecations

emmadesilva · web-flow · commit 0e441f43282e · 2023-02-12T21:55:59.000+01:00
Remove deprecated BuildTaskService::findTasksInAppDirectory() method from the public API
diff --git a/packages/framework/src/Framework/Services/BuildTaskService.php b/packages/framework/src/Framework/Services/BuildTaskService.php
@@ -52,10 +52,7 @@ public function getPostBuildTasks(): array
         );
     }
 
-    /**
-     * @deprecated Public usage of this method is deprecated as the method will be made protected.
-     */
-    public static function findTasksInAppDirectory(): array
+    protected static function findTasksInAppDirectory(): array
     {
         $tasks = [];
 
diff --git a/packages/framework/tests/Feature/Services/BuildTaskServiceTest.php b/packages/framework/tests/Feature/Services/BuildTaskServiceTest.php
@@ -186,7 +186,7 @@ public function test_find_tasks_in_app_directory_method_discovers_tasks_in_app_d
         File::makeDirectory(Hyde::path('app/Actions'));
         Hyde::touch('app/Actions/FooBuildTask.php');
 
-        $this->assertEquals(['App\Actions\FooBuildTask'], BuildTaskService::findTasksInAppDirectory());
+        $this->assertEquals(['App\Actions\FooBuildTask'], (new BuildTaskService())->getPostBuildTasks());
         File::deleteDirectory(Hyde::path('app/Actions'));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -52,10 +52,7 @@ public function getPostBuildTasks(): array`
`52`	`52`	`);`
`53`	`53`	`}`
`54`	`54`
`55`		`- /**`
`56`		`- * @deprecated Public usage of this method is deprecated as the method will be made protected.`
`57`		`- */`
`58`		`- public static function findTasksInAppDirectory(): array`
	`55`	`+ protected static function findTasksInAppDirectory(): array`
`59`	`56`	`{`
`60`	`57`	`$tasks = [];`
`61`	`58`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ public function test_find_tasks_in_app_directory_method_discovers_tasks_in_app_d`
`186`	`186`	`File::makeDirectory(Hyde::path('app/Actions'));`
`187`	`187`	`Hyde::touch('app/Actions/FooBuildTask.php');`
`188`	`188`
`189`		`- $this->assertEquals(['App\Actions\FooBuildTask'], BuildTaskService::findTasksInAppDirectory());`
	`189`	`+ $this->assertEquals(['App\Actions\FooBuildTask'], (new BuildTaskService())->getPostBuildTasks());`
`190`	`190`	`File::deleteDirectory(Hyde::path('app/Actions'));`
`191`	`191`	`}`
`192`	`192`