Merge pull request #1004 from hydephp/remove-markdowncollection-class

emmadesilva · web-flow · commit 0d0eb49a3bbe · 2023-02-12T22:06:37.000+01:00
Removes deprecated MarkdownCollection class
diff --git a/app/config.php b/app/config.php
@@ -101,7 +101,6 @@
         'MarkdownPost' => \Hyde\Pages\MarkdownPost::class,
         'DocumentationPage' => \Hyde\Pages\DocumentationPage::class,
         'Filesystem' => \Hyde\Facades\Filesystem::class,
-        'MarkdownCollection' => \Hyde\Framework\Features\DataCollections\Facades\MarkdownCollection::class,
     ],
 
 ];
diff --git a/packages/framework/src/Framework/Features/DataCollections/Facades/MarkdownCollection.php b/packages/framework/src/Framework/Features/DataCollections/Facades/MarkdownCollection.php
diff --git a/packages/framework/tests/Feature/DataCollectionTest.php b/packages/framework/tests/Feature/DataCollectionTest.php
@@ -6,17 +6,14 @@
 
 use ArgumentCountError;
 use Hyde\Framework\Features\DataCollections\DataCollection;
-use Hyde\Framework\Features\DataCollections\Facades\MarkdownCollection;
 use Hyde\Hyde;
 use Hyde\Markdown\Models\MarkdownDocument;
 use Hyde\Testing\TestCase;
-use Illuminate\Foundation\AliasLoader;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\File;
 
 /**
  * @covers \Hyde\Framework\Features\DataCollections\DataCollection
- * @covers \Hyde\Framework\Features\DataCollections\Facades\MarkdownCollection
  */
 class DataCollectionTest extends TestCase
 {
@@ -145,21 +142,6 @@ public function test_static_markdown_helper_doest_not_ignore_files_starting_with
         File::deleteDirectory(Hyde::path('resources/collections/foo'));
     }
 
-    public function test_markdown_facade_returns_same_result_as_static_markdown_helper()
-    {
-        $expected = DataCollection::markdown('foo');
-        $actual = MarkdownCollection::get('foo');
-        unset($expected->parseTimeInMs);
-        unset($actual->parseTimeInMs);
-        $this->assertEquals($expected, $actual);
-    }
-
-    public function test_data_collection_service_provider_registers_the_facade_as_an_alias()
-    {
-        $this->assertArrayHasKey('MarkdownCollection', AliasLoader::getInstance()->getAliases());
-        $this->assertContains(MarkdownCollection::class, AliasLoader::getInstance()->getAliases());
-    }
-
     public function test_class_has_static_source_directory_property()
     {
         $this->assertEquals('resources/collections', DataCollection::$sourceDirectory);
