Merge pull request #1246 from hydephp/make-hydepage-title-property-readonly

emmadesilva · web-flow · commit 00b2e743f5fe · 2023-03-11T15:05:58.000+01:00
Make HydePage::$title property readonly
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -13,7 +13,7 @@ This serves two purposes:
 - for new features.
 
 ### Changed
-- for changes in existing functionality.
+- Made the `HydePage::$title` property readonly
 
 ### Deprecated
 - HydePage::$canonicalUrl
diff --git a/packages/framework/src/Pages/Concerns/HydePage.php b/packages/framework/src/Pages/Concerns/HydePage.php
@@ -66,7 +66,7 @@ abstract class HydePage implements PageSchema, SerializableContract
     public PageMetadataBag $metadata;
     public NavigationData $navigation;
 
-    public string $title;
+    public readonly string $title;
 
     /** @deprecated v1.0.0-RC.3 - This property requires information that is setup-dependent, and will work better through a runtime accessor. Since it is mainly related to blog posts, it will be moved there. */
     public ?string $canonicalUrl;
diff --git a/packages/framework/tests/Feature/HydePageTest.php b/packages/framework/tests/Feature/HydePageTest.php
@@ -370,9 +370,7 @@ public function test_all_returns_collection_of_all_parsed_source_files_from_page
             MarkdownPage::all()
         );
         $this->assertEquals(
-            ['_pages/foo.md' => tap(new MarkdownPage('foo'), function ($page) {
-                $page->title = 'Foo';
-            })],
+            ['_pages/foo.md' => (new MarkdownPage('foo'))],
             MarkdownPage::all()->all()
         );
         Filesystem::unlink('_pages/foo.md');
