Repository navigation
Update wrapping.rst - example for unauthenticated unwrap - #789
Merged
Merged
Conversation
nneul
changed the title
Contributor
Author
|
ping or close it please so it's not hanging around |
Contributor
Author
|
HVAC maintainers - please consider actually merging this. |
colin-pm
previously requested changes
Dec 14, 2022
colin-pm
left a comment
colin-pm
left a comment
Member
There was a problem hiding this comment.
One small nit, but overall the doc change looks good to me. Sorry for the delay.
nneul
force-pushed
the
additional-unwrap-example
branch
from
December 14, 2022 19:28
30495dc to
83d2a29
Compare
briantist
added
the
documentation
Provide example of using unwrap with just the wrapping token. Previous example is non-functional unless already authenticated.
briantist
force-pushed
the
additional-unwrap-example
branch
from
January 27, 2023 23:44
83d2a29 to
026eb38
Compare
Codecov Report
@@ Coverage Diff @@
## develop #789 +/- ##
===========================================
+ Coverage 81.34% 83.51% +2.17%
===========================================
Files 65 65
Lines 2969 3003 +34
===========================================
+ Hits 2415 2508 +93
+ Misses 554 495 -59
|
Contributor
|
Hi @nneul ! I'd also like to apologize for the delays. I've updated your PR today to rebase it, and fix up the example so that it passes (we run live tests on examples and it needed some updates). Calling attention to this doc also made me realize it was totally not showing the correct unwrap method documentation at all, and also included something from the Seal backend, so I've cleaned that up as well. Thanks very much for the contribution! |
briantist
approved these changes
Jan 28, 2023
briantist
added a commit
that referenced
this pull request
Mar 6, 2023
* Update wrapping.rst Provide example of using unwrap with just the wrapping token. Previous example is non-functional unless already authenticated. * update example * correct automethod name * doctest fixes --------- Co-authored-by: Brian Scholer <[email protected]>
briantist
added a commit
to briantist/hvac
that referenced
this pull request
May 10, 2023
* Update wrapping.rst Provide example of using unwrap with just the wrapping token. Previous example is non-functional unless already authenticated. * update example * correct automethod name * doctest fixes --------- Co-authored-by: Brian Scholer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide example of using unwrap with just the wrapping token. Previous example is non-functional unless already authenticated.