Skip to content

deps: Upgrade @biomejs/biome,@vercel/ncc & cspell - #173

Merged
hustcer merged 2 commits into
mainfrom
develop
Sep 19, 2025
Merged

deps: Upgrade @biomejs/biome,@vercel/ncc & cspell#173
hustcer merged 2 commits into
mainfrom
develop

Conversation

@hustcer

@hustcer hustcer commented Sep 19, 2025

Copy link
Copy Markdown
Owner

deps: Upgrade @biomejs/biome,@vercel/ncc & cspell

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies to newer patch releases for improved stability and compatibility.
    • Streamlined continuous integration by removing an older Nu version from the test matrix; remaining versions continue to be validated across supported environments.

@coderabbitai

coderabbitai Bot commented Sep 19, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Removed Nu 0.87.1 from the CI test matrix in .github/workflows/full-matrix.yaml. Updated several devDependencies in package.json (biome, @types/node, @types/semver, @vercel/ncc, cspell, lefthook). No functional code or public API changes.

Changes

Cohort / File(s) Summary of Changes
CI matrix update
.github/workflows/full-matrix.yaml
Dropped Nu version 0.87.1 from test-matrix ver list; remaining versions: 0.93.0, 0.92.2, 0.91.0, 0.90.1, 0.89.0, 0.88.1. No other workflow logic changes.
Dev tooling bumps
package.json
Updated devDependencies: biome ^2.2.2→^2.2.4, @types/node ^24.3.0→^24.5.2, @types/semver ^7.7.0→^7.7.1, @vercel/ncc ^0.38.3→^0.38.4, cspell ^9.2.0→^9.2.1, lefthook ^1.12.3→^1.13.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A whisk of versions, hop-hop—gone,
0.87 hops off the lawn.
Tools get shiny, lint winds hum,
Types and hooks go thrum-thrum-thrum.
In CI fields I nibble hay—
Green checks bloom. Ship away! 🐇✨

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb94121 and 25bc000.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .github/workflows/full-matrix.yaml (1 hunks)
  • package.json (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Code Analysis

  • Dependency version updates across multiple packages (Biome, Node types, semver types, NCC, cspell, lefthook)
  • All updates appear to be minor/patch version bumps following semantic versioning
  • No breaking changes expected based on version increments
  • Maintains consistent development tooling ecosystem

Security Review

  • ✅ NCC update from 0.38.3 to 0.38.4 likely includes security patches
  • ✅ cspell update from 9.2.0 to 9.2.1 may include dictionary/security improvements
  • ✅ lefthook update from 1.12.3 to 1.13.1 could include security enhancements
  • ✅ All updates are to trusted, widely-used development tools

Optimization Suggestions

  • Consider adding --prefer-offline flag to npm/yarn installs to cache these dev dependencies
  • Evaluate if any of these tools could be moved to optional dependencies if not used in all workflows
  • Monitor bundle size impact from NCC update (though minimal for dev dependencies)

Overall Quality: 4

@github-actions

Copy link
Copy Markdown

Code Analysis

  • This appears to be a GitHub Actions workflow and package.json update, not frontend React/Vue code
  • Changes involve CI/CD configuration and dependency version bumps
  • Removed Nu version 0.87.1 from testing matrix
  • Updated multiple devDependencies to newer patch versions

Security Review

  • Dependency updates include security patches (e.g., @biomejs/biome 2.2.2 → 2.2.4)
  • @types/node update (24.3.0 → 24.5.2) likely includes security fixes
  • lefthook update (1.12.3 → 1.13.1) may contain security improvements
  • No obvious security vulnerabilities introduced in these changes

Optimization Suggestions

  • Consider adding caching to GitHub Actions workflow for faster CI runs
  • Evaluate if all tested Nu versions are still necessary for maintenance
  • Monitor bundle size impact from dependency updates (though minimal for devDependencies)

Overall Quality: 4
(Note: This review focuses on infrastructure/config changes rather than frontend code. The changes appear to be routine maintenance and dependency updates with no concerning patterns.)

@hustcer
hustcer merged commit b2f2b0f into main Sep 19, 2025
126 of 127 checks passed
@github-actions github-actions Bot added this to the v3.21 milestone Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant