feat: Update setup Nu for future versions of Nu - #157

src/plugins.ts:44

• [nitpick] The comment could be expanded to explain why splitting on '.' is safe for all plugin filenames and how it handles names with multiple dots.

        # "split row . | first" used to handle binary with .exe extension

src/plugins.ts:43

• The new filtering logic, especially handling .exe extensions, should have dedicated unit tests to verify correct behavior across different plugin name patterns.

      $allPlugins | reduce -f [] {|it, acc|

.github/workflows/full-matrix.yaml (1)

43-46: Guard $nu.current-exe usage for Nushell < 0.101.0

$nu.current-exe was only introduced in Nushell 0.101.0 (released Dec 24, 2024)1, so referencing it in older versions (e.g. 0.86) will cause the step to fail at runtime.

Suggested fixes:

• Restrict the test matrix to Nushell >= 0.101.0.
• Or provide a fallback for older releases, e.g. use which nu when $nu.current-exe is undefined.

Location:

• .github/workflows/full-matrix.yaml: lines 43–46

src/plugins.ts (1)

43-50: Consider reverting to the simpler filter approach.

The change from filter to reduce makes the code more verbose without providing additional benefits. The original filter approach was more concise and readable:

-      $allPlugins | reduce -f [] {|it, acc|
-        # "split row . | first" used to handle binary with .exe extension
-        if $enablePlugins =~ ($it.name | path basename | split row . | first) {
-          $acc | append $it
-        } else {
-          $acc
-        }
-      }
+      $allPlugins | filter {|it|
+        # "split row . | first" used to handle binary with .exe extension
+        $enablePlugins =~ ($it.name | path basename | split row . | first)
+      }

README.zh-CN.md (1)

51-52: Great simplification, but keep examples consistent.

Switching from ((which nu).path.0 | path dirname) to ($nu.current-exe | path dirname) removes the array‐indexing hack – nice.
However, earlier in the same README we still print the path with (which nu). Consider updating the remaining occurrences so newcomers don’t wonder why two different idioms are used.

-    print $'Nu path:(which nu)(char nl)'
+    print $'Nu path:($nu.current-exe)(char nl)'

.github/workflows/basic.yaml (1)

55-59: Update the matching “Nu path” print for coherence

Now that directory discovery relies on $nu.current-exe, printing the binary path via which nu feels uneven. Unless you purposely want to demo both ways, align them:

-        print $'Nu path:(which nu)(char nl)'
+        print $'Nu path:($nu.current-exe)(char nl)'

README.md (1)

55-56: Keep documentation consistent across languages

Same inconsistency here as in the Chinese README: we switched the ls example but left the “Nu path” line untouched. Recommend updating for uniformity (see diff below).

-    print $'Nu path:(which nu)(char nl)'
+    print $'Nu path:($nu.current-exe)(char nl)'

.github/workflows/main-matrix.yaml (1)

38-41: Same consistency & compatibility notes as above

1. Consider changing the preceding “Show Nu Binary Path” step to use $nu.current-exe for symmetry.
2. Confirm $nu.current-exe exists for all versions in this matrix, otherwise gate the dir-listing step with a version check.

-      run: print $'Nu path:(which nu)(char nl)'
+      run: print $'Nu path:($nu.current-exe)(char nl)'

nu/register-plugins.nu (1)

36-43: Consider reverting to the more idiomatic filter approach.

The change from filter to reduce adds unnecessary complexity without functional benefit. The original filter approach would be cleaner and more idiomatic:

-      $allPlugins | reduce -f [] {|it, acc|
-        # "split row . | first" used to handle binary with .exe extension
-        if $enablePlugins =~ ($it.name | path basename | split row . | first) {
-          $acc | append $it
-        } else {
-          $acc
-        }
-      }
+      $allPlugins | filter {|it|
+        # "split row . | first" used to handle binary with .exe extension
+        $enablePlugins =~ ($it.name | path basename | split row . | first)
+      }

The filter approach is more concise, readable, and semantically appropriate for this use case.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro