fix(ContextMenu): Ensure props are applied correctly when force mounted #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e9b87b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
82 tasks
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
huntabyte
approved these changes
Jan 5, 2026
Owner
huntabyte
left a comment
huntabyte
left a comment
There was a problem hiding this comment.
Thanks man! Missed that as well on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1911 I added these props back but missed that they needed to be added to both the forceMount and non-forceMount versions of the component. This PR aims to both fix that issue and also prevent similar things from happening in the future.
Now common props are included in the mergeProps call so that they are spread onto both without having to duplicate each prop.