🦋 Changeset detected

Latest commit: 70d9594

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Could you not just pass type="submit" to the checkbox?

I think we just don't prevent default when enter is pressed if type="submit" seems like a simpler fix here

Ah but I guess that would still strigger a "click" event on the button thus changing the state, so this solution might be best after all. I do still think we should detect the type prop and only submit if it's type="submit"

Ah but I guess that would still strigger a "click" event on the button thus changing the state, so this solution might be best after all. I do still think we should detect the type prop and only submit if it's type="submit"

yes exactly, the click event is detected instead. ok I will update the code to reflect that change

wait, don't you think that having the type="submit" is irrelevant for this usecase? in svelte it's possible to submit the form when pressing "Enter" on a checkbox even without the type="submit".

demo

wait, don't you think that having the type="submit" is irrelevant for this usecase? in svelte it's possible to submit the form when pressing "Enter" on a checkbox even without the type="submit".

You're comparing an <input type="checkbox" /> to a Bits UI checkbox which renders a <button> to support tri-state.

Done, any other suggestion?

btw, do you think other components should have the same behaviour? e.g. the radio-group, the switch, etc