use minValue and maxValue to generate a defaultPlaceholder for date inputs #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3695dd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
zomchak-code
force-pushed
the
fix/date-default-placeholder
branch
2 times, most recently
from
ad608e9 to
67665cc
Compare
zomchak-code
force-pushed
the
fix/date-default-placeholder
branch
from
67665cc to
4b92e14
Compare
Owner
|
Hey thanks for this! Would you mind adding tests that fail without this behavior but pass with it to ensure a regression isn't accidentally introduced in the future? |
Contributor
Author
|
@huntabyte done |
Contributor
Author
|
@huntabyte please let me know what else can I do to help get this over the line |
Owner
|
Nothing more needed. Will give this another review tomorrow and merge/release. Thanks a ton for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1873.
This PR makes sure for various date inputs that:
In case current date is outside of
minValuemaxValuerange - default placeholder will be the closest allowed value to current date.