Add alloptions workaround. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much like in humanmade/memcache-object-cache@a471be4 we workaroudn the core behaviour of storing all options in a single memcached object, which causes a lot of race conditions. Instead, we hook in on add / set / get and delete and specially handle the alloptions key, to split it up and store them each in their own memcached object,
rmccue
requested changes
Sep 23, 2016
| @@ -1185,6 +1189,10 @@ public function delete( $key, $group = 'default', $time = 0, $server_key = '', $ | |||
| return true; | |||
| } | |||
|
|
|||
| if ( $key === 'alloptions' && $group === 'options' ) { | |||
| return $this->deleteAllOptions(); | |||
| } | |||
There was a problem hiding this comment.
This can be moved above the other lines here.
| @@ -1286,6 +1294,9 @@ public function get( $key, $group = 'default', $force = false, &$found = null, $ | |||
| // Assume object is not found | |||
| $found = false; | |||
|
|
|||
| if ( $key === 'alloptions' && $group === 'options' ) { | |||
| return $this->getAllOptions(); | |||
| } | |||
There was a problem hiding this comment.
This can also be moved to the top.
|
Ok fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like in
humanmade/memcache-object-cache@a471be4
we workaroudn the core behaviour of storing all options in a single
memcached object, which causes a lot of race conditions. Instead, we
hook in on add / set / get and delete and specially handle the
alloptions key, to split it up and store them each in their own
memcached object,