⚓ [vllm] ensure MASTER_ADDR/MASTER_PORT are set safely #4057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
changed the title
singing-cat
pushed a commit
to singing-cat/trl
that referenced
this pull request
Sep 23, 2025
) Co-authored-by: Quentin Gallouédec <[email protected]>
qgallouedec
added a commit
that referenced
this pull request
Sep 23, 2025
Co-authored-by: Quentin Gallouédec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pr do?
fixes #3979
This pull request improves the way distributed training environment variables are set for trainers in the
trlpackage. Instead of hardcoding or defaulting to potentially conflicting values forMASTER_ADDRandMASTER_PORT, a new utility function is introduced to safely and automatically select a free port, reducing the risk of collisions during concurrent runs.Distributed training environment setup improvements:
ensure_master_addr_portintrl/trainer/utils.pythat setsMASTER_ADDRand chooses a freeMASTER_PORTif not already set, or if set to "0" or "auto", to avoid port collisions in distributed training.trl/trainer/grpo_trainer.py,trl/trainer/online_dpo_trainer.py, andtrl/trainer/rloo_trainer.pyto includeensure_master_addr_port. [1] [2] [3]MASTER_ADDRandMASTER_PORTin the constructors ofGRPOTrainer,OnlineDPOTrainer, andRLOOTrainerwith calls toensure_master_addr_port, ensuring safer distributed setup. [1] [2] [3]osandsocketintrl/trainer/utils.pyto support the new utility function.