Updated Reformer to use caching during generation#8252
Closed
guillaume-be wants to merge 1 commit into
Closed
Conversation
past_buckets_states to possible output cached states
Contributor
|
Great catch! |
Contributor
|
Let's merge that quickly so that I can integrate it into https://github.com/huggingface/transformers/pull/6949/files#diff-b7601d397d5d60326ce61a9c91beaa2afa026014141052b32b07e1d044fbbe17 |
7 tasks
Contributor
|
Actually, we would have to add in two spots of this Mentioned your PR at the fix - hope it's ok for you to close this PR to avoid any more merge conflicts. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current reformer implementation supports caching of buckets and states, but this is not used during generation. Running a generation example in debugging mode, such as
One can see that the
past_buckets_statespassed to the attention are alwaysNone(attransformers/src/transformers/modeling_reformer.py
Line 365 in 504ff7b
This is because the name of the past states for the reformer are neither
past_key_valuesormems.This PR adds the name of the past states to the generation
pastallocation.Generally, it may make sense to harmonize the
pastvalue for all models, so that thegeneratefunction generalizes betterWho can review?
Text Generation: @patrickvonplaten, @TevenLeScao
Reformer: @patrickvonplaten