Minor error fix of 'bart-large-cnn' details in the pretrained_models doc#8053
Merged
Merged
Conversation
Collaborator
|
Thanks! |
Contributor
Author
|
Thank you, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that there seemed to be a mistake regarding "facebook/bart-large-cnn" in the pretrained_models doc.
What does this PR do?
While I check the model explanations in the pretrained_models doc, I found that there seemed to be a mistake.
Regarding
facebook/bart-large-cnn, the details of the model is as follows:If my understanding is correct, it seems that
12-layerand(same as base)should be24-layerand(same as large).I asked a question in the forum about this:
https://discuss.huggingface.co/t/there-seems-to-be-a-mistake-in-documentation-pretrained-models-html-regarding-bart/1746/
Before submitting
Pull Request section?
to the it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
documentation: @sgugger
(Thank you for kindly answering my question in the forum!)