Skip to content

Fix Rag example docstring#7872

Merged
patrickvonplaten merged 2 commits intohuggingface:masterfrom
patrickvonplaten:fix_rag_examples
Oct 17, 2020
Merged

Fix Rag example docstring#7872
patrickvonplaten merged 2 commits intohuggingface:masterfrom
patrickvonplaten:fix_rag_examples

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten commented Oct 17, 2020 •
edited
Loading

What does this PR do?

Fixes #7829

Before submitting

  • This PR fixes a typo or improves the docs (you can dimiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to the it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@patrickvonplaten patrickvonplaten linked an issue Oct 17, 2020 that may be closed by this pull request
RAG generate function uses input_ids even when context_input_ids are given. #7871
Closed
2 tasks
@patrickvonplaten patrickvonplaten merged commit f5c45a1 into huggingface:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@patrickvonplaten