Flos fix#7384
Merged
Merged
Conversation
sgugger
reviewed
Sep 25, 2020
|
|
||
| @staticmethod | ||
| def _actual_model( | ||
| model: Union[torch.nn.DataParallel, torch.nn.parallel.DistributedDataParallel, torch.nn.modules.Module] |
Collaborator
There was a problem hiding this comment.
nit: aren't them all subclasses of torch.nn.Module?
Contributor
Author
There was a problem hiding this comment.
I wanted to be explicit, but I can change it if you think that's required.
sgugger
approved these changes
Sep 25, 2020
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for the quick fix! This LGTM.
sirmammingtonham
added a commit
to sirmammingtonham/transformers
that referenced
this pull request
Sep 26, 2020
TevenLeScao
reviewed
Sep 26, 2020
Contributor
Author
|
Please merge at will, as this fix is blocking us (#7146 (comment)). |
LysandreJik
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7146
This basically unwraps the model that is used during training and can be either plain
ModuleorDataParallel/DistributedDataParallel.