Skip to content

[s2s] run_eval.py parses generate_kwargs #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sshleifer merged 4 commits into from
Sep 4, 2020
Merged

[s2s] run_eval.py parses generate_kwargs #6948

sshleifer merged 4 commits into from
Sep 4, 2020

Conversation

@sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Sep 4, 2020 •
edited
Loading

You can now run

td=test_data/wmt_en_ro
python run_eval.py t5-base $td/val.source preds.txt --reference_path $td/val.target \
        --score_path metrics.json --length_penalty 0.2 \
         --task translation_en_to_ro --num_beams 2 --n_obs 2 --bs 1 --length_penalty 0.6

h/t @stas00 in #6369

@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #6948 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6948      +/-   ##
==========================================
+ Coverage   80.01%   80.54%   +0.52%     
==========================================
  Files         161      161              
  Lines       30120    30120              
==========================================
+ Hits        24102    24259     +157     
+ Misses       6018     5861     -157
Impacted Files Coverage Δ
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.81%) ⬇️
src/transformers/data/data_collator.py 86.63% <0.00%> (-5.27%) ⬇️
src/transformers/generation_tf_utils.py 84.21% <0.00%> (-2.26%) ⬇️
src/transformers/modeling_tf_utils.py 87.29% <0.00%> (+0.32%) ⬆️
src/transformers/modeling_tf_electra.py 98.95% <0.00%> (+73.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6078b12...2f212d3. Read the comment docs.

@stas00
Copy link
Contributor

stas00 commented Sep 4, 2020

Yes, please and thank you!!! Needing it badly!

@stas00 stas00 mentioned this pull request Sep 4, 2020
Merged
@sshleifer
Copy link
Contributor Author

sshleifer commented Sep 4, 2020

Here you go!

@sshleifer sshleifer merged commit a4fc0c8 into huggingface:master Sep 4, 2020
@sshleifer sshleifer deleted the t5-repl branch September 4, 2020 18:19
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
@sshleifer @Zigur
[s2s] run_eval.py parses generate_kwargs (huggingface#6948)
9326991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sshleifer @stas00