[Longformer] fix longformer global attention output#5659
Merged
patrickvonplaten merged 6 commits intoJul 13, 2020
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #5659 +/- ##
==========================================
- Coverage 77.01% 76.87% -0.14%
==========================================
Files 128 145 +17
Lines 21615 25369 +3754
==========================================
+ Hits 16646 19502 +2856
- Misses 4969 5867 +898
Continue to review full report at Codecov.
|
patrickvonplaten
changed the title
patrickvonplaten
changed the title
Contributor
Author
|
Global and Local attention probs have now always the same output shape. This is both more consistent in terms of the output signature for the user and solves the multi-gpu issue. |
Contributor
Author
|
Pinging @thomwolf @sshleifer @LysandreJik @sgugger for notification -> more details can be found in issue: #5646. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the attention probs that are outputted when longformer uses global attention and sets
output_attention=True.Thanks a million to @k141303 for very clean issue + perfect proposed solution in #5646 .