Remove deprecated training args and is_fast property#46917
Merged
Rocketknight1 merged 1 commit intoJul 22, 2026
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: byt5 |
cyyever
force-pushed
the
cleanup/overdue-deprecations
branch
from
June 26, 2026 12:25
f1337e6 to
d8887ad
Compare
Member
|
cc @SunMarc if we're okay to remove these! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated APIs from the Transformers codebase, primarily by deleting legacy TrainingArguments parameters and related deprecation-handling code.
Changes:
- Removed deprecated
TrainingArguments.warmup_ratioandTrainingArguments.logging_dir, plus their associated__post_init__warnings/migration logic. - Removed the deprecated
warmup_ratioparameter fromTrainingArguments.set_lr_scheduler. - Removed the deprecated
is_fastproperty from the image processing backend implementations (Torchvision/PIL backends).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/transformers/training_args.py |
Drops deprecated training-argument fields and cleans up deprecated scheduler-arg plumbing. |
src/transformers/image_processing_backends.py |
Removes deprecated is_fast property in favor of the backend attribute. |
cyyever
force-pushed
the
cleanup/overdue-deprecations
branch
from
July 22, 2026 04:27
d8887ad to
ba2d03d
Compare
cyyever
changed the title
is_fast property
Contributor
Author
|
@SunMarc @Rocketknight1 It's ready. |
Signed-off-by: cyy <[email protected]>
cyyever
force-pushed
the
cleanup/overdue-deprecations
branch
from
July 22, 2026 04:30
ba2d03d to
6988efc
Compare
Contributor
CI recapDashboard: View test results in Grafana |
Rocketknight1
enabled auto-merge
July 22, 2026 12:44
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SangbumChoi
added a commit
to SangbumChoi/transformers
that referenced
this pull request
Jul 22, 2026
* upstream/main: (39 commits) Remove deprecated training args and `is_fast` property (huggingface#46917) Consistent output shape from `get_image_features` (huggingface#46405) Fix multi-device mxfp4 dequantization race in `_convert_moe_packed_tensors` (huggingface#47423) fix failed test cases for qwen3_omni_moe model (huggingface#47449) Fix Hunyuan-VL PIL image resize parity with reference preprocessing (huggingface#47233) Move `value` padding into the attention interfaces that need it (huggingface#47451) Simplify function dispatch for linear attention (huggingface#47450) [cache] Allow sliding window layers to be roll-backed for speculative decoding (huggingface#47447) Fix double-shifted training loss in GitForCausalLM (huggingface#47395) Fix CohereASR training-loss double-shift (same as Moonshine fix huggingface#46784) (huggingface#46895) Warn when `group_by_length` is silently ignored for iterable datasets (huggingface#47379) Update bug report list (huggingface#46607) Fix shape mismatch in KyutaiSpeechToText `generate()` last window (huggingface#46952) Optimize flash attention max seqlen computation in vision attention (huggingface#47170) fix: remove unreachable return in special token builder (huggingface#47420) Add Harry to slow CI (huggingface#47454) BLT: vectorize patch length processing (huggingface#47385) Fix `TrackioCallback` fails to log evaluation metrics after training ends (huggingface#46935) [Kimi] add integration tests (huggingface#47383) Fix typo in `MusicgenForCausalLM.generate()` (huggingface#46974) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes overdue deprecations:
Deprecated
TrainingArgumentsfieldswarmup_ratioandlogging_dir(plus their__post_init__migration logic and thewarmup_ratioarg inset_lr_scheduler). Docs updated to usewarmup_steps(which accepts a float ratio).Deprecated
is_fastproperty from image processing backends (superseded by thebackendattribute).I confirm that this is not a pure code agent PR.
Who can review?
trainer: @SunMarc