Remove dead beam-search dummies from dummy_pt_objects.py#45722
Merged
Conversation
Rocketknight1
approved these changes
Apr 30, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45712
What does this PR do?
Removes six dead dummy classes from
dummy_pt_objects.py:BeamScorer,ConstrainedBeamSearchScorer,Constraint,ConstraintListState,DisjunctiveConstraint,PhrasalConstraint.The real implementations were removed in v5 (#41223) but the dummies stayed. None of the six is referenced anywhere under
src/,tests/,docs/, or inMIGRATION_GUIDE_V5.md. Without torch they leak intodir(transformers)andutils/check_repo.pyfails the public-init-vs-docs invariant.After removal,
from transformers import BeamScorerraisesImportErrorin a no-torch env (matching the with-torch behavior) instead of returning the dummy and producing a misleadingrequires backend torcherror on use.DEPRECATED_OBJECTSincheck_repo.pywould be the alternative, but that list is for objects that still exist as aliases or shims (e.g.PretrainedConfig→PreTrainedConfig). These six don't.Tests run (no-torch venv):
Code Agent Policy
AI assistance (Claude) was used during investigation and patch preparation. All changes were reviewed and tested by me.
Before submitting
Pull Request section?
dummy_pt_objects.pyfailcheck_repo.pyand leak intodir(transformers)without torch #45712, approved by @Rocketknight1)documentation guidelines, and
here are tips on formatting docstrings.