Skip to content

Idefics2 Fast Image processor #37168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sushmanthreddy wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Idefics2 Fast Image processor #37168

sushmanthreddy wants to merge 8 commits into from

Conversation

@sushmanthreddy
Copy link
Contributor

@sushmanthreddy sushmanthreddy commented Apr 1, 2025

close #36978

@github-actions github-actions bot marked this pull request as draft April 1, 2025 10:59
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@sushmanthreddy sushmanthreddy changed the title Idefics Idefics2 Fast Image processor Apr 1, 2025
@sushmanthreddy
Copy link
Contributor Author

sushmanthreddy commented Apr 1, 2025

@yonigozlan

This is the Idefics 2 fast image processor ,got some issue closed that pr

@sushmanthreddy sushmanthreddy marked this pull request as ready for review April 1, 2025 11:08
@github-actions github-actions bot requested review from ydshieh and yonigozlan April 1, 2025 11:08
@yonigozlan yonigozlan mentioned this pull request Apr 2, 2025
Closed
81 tasks
yonigozlan
yonigozlan reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sushmanthreddy ! Thanks a lot for working on this. Overall it looks great, but I'm actually working on a refactor of the processing in idefics2/idefics3/smolvlm family which will impact this PR, here's the PR in question: #37291

Basically it will change the processing of batched images to fully flattened images, so it should simplify this PR.

I advise waiting for this refactor to be merged before iterating on this PR, I'll ping here when it's done!

@yonigozlan yonigozlan mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonigozlan yonigozlan yonigozlan left review comments

@ydshieh ydshieh Awaiting requested review from ydshieh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Contributions Welcome] Add Fast Image Processors

2 participants

@sushmanthreddy @yonigozlan