Skip to content

Uniformize OwlViT and Owlv2 processors#35700

Merged
yonigozlan merged 10 commits into
huggingface:mainfrom
yonigozlan:uniformize-owl-processor
Feb 13, 2025
Merged

Uniformize OwlViT and Owlv2 processors#35700
yonigozlan merged 10 commits into
huggingface:mainfrom
yonigozlan:uniformize-owl-processor

Conversation

@yonigozlan

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds uniformized processors following #31911 for OwlViT and Owlv2.
Split from this PR #32841

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yonigozlan yonigozlan mentioned this pull request Jan 14, 2025
40 tasks
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel qubvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's super nice in terms of standardization!

Comment thread src/transformers/models/owlv2/processing_owlv2.py
@qubvel

qubvel commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

@yonigozlan I found this one is required for my PR for zero-short pipeline to work as well 😄 so, it's perfect timing

Comment thread tests/models/owlv2/test_processor_owlv2.py
@yonigozlan

Copy link
Copy Markdown
Contributor Author

@ArthurZucker This is ready for your review :)

@qubvel

qubvel commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Also, it should be possible not to run slow tests with "run-slow: owlvit, owlv2" comment if you merge the latest main

@qubvel

qubvel commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

It triggers with the GitHub comment "run-slow: owlvit, owlv2"

P.S. job name to check tests running "pytest/custom-tests"

@qubvel

qubvel commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

run-slow: owlvit, owlv2

@github-actions

Copy link
Copy Markdown
Contributor

This comment contains run-slow, running the specified jobs: ['models/owlv2', 'models/owlvit'] ...

@yonigozlan

Copy link
Copy Markdown
Contributor Author

It triggers with the GitHub comment "run-slow: owlvit, owlv2"

Oh cool thanks, so run-slow doesn't work anymore with a commit message?

@qubvel

qubvel commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

AFAIK not anymore, it was disabled

Comment on lines 174 to 175
if len(t) != max_num_queries:
t = t + [" "] * (max_num_queries - len(t))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit (and bumping PR up in the meantime, cc @ArthurZucker ) but here would be nice to remove single-letter variables

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@yonigozlan
yonigozlan merged commit 336dc69 into huggingface:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants