gpt2: enable model_parallel for xpu backend#35253
Conversation
Signed-off-by: Dmitry Rogozhkin <[email protected]>
|
This seems sporadic ci failure unrelated to PR: |
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! Thanks, these functions are completely deprecated and the recommended API is to use accelerate's device_map = "auto" instead!
Thank you for you feedback. I saw deprecation warnings and that's why I implemented this only for one model :). @ArthurZucker : I am trying to make ci passing clean for XPU backend. I totally understand if maintainers want to avoid changing deprecated stuff which will be dropped at some point. However I would like to raise a question on what can be done for the sake of clean ci? If decision is (and your reply hints it is) to not enable model_parallel for other non-CUDA backends, then associated tests should probably be marked as CUDA specific and excluded for non-CUDA. If that's the direction - I will submit another PR to mark these tests as CUDA specific. |
|
Let's mark these tests as cuda specific. Thanks for your contribution! |
Will do. Thank you for guidance! |
|
I've submitted #35269 to mark tests with |
For: #35252
CC: @ArthurZucker @SunMarc