uniformize kwargs for VisionTextDualEncoder#34563
Conversation
|
@molbap I changed the order of |
a1626ed to
0decb11
Compare
|
Hi @tibor-reiss , you can use |
Done, could you please check again @molbap? |
|
Friendly reminder @molbap |
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Thanks for uniformizing this! cc @ArthurZucker for core review
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
A nit butLGTM otherwise!
| class VisionTextDualEncoderProcessorKwargs(ProcessingKwargs, total=False): | ||
| _defaults = {} |
There was a problem hiding this comment.
if there are no defualt we can just use the processingKwargs directly!
There was a problem hiding this comment.
I don't think that is possible because _merge_kwargs: it requires _defaults - https://github.com/huggingface/transformers/blob/main/src/transformers/processing_utils.py#L1056
If you would like to, I could open another PR to have _defaults included in the parent, ProcessingKwargs - that would also make mypy happy :)
1ff76b6 to
e9982a4
Compare
|
Rebased |
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks and sorry for the delay!
* Make kwargs uniform for VisionTextDualEncoder * Add bc for flipped args
4 participants
Adds uniformized processors for VisionTextDualEncoder following #31911.
@qubvel @molbap