[docs] Fix GenerationConfig params#34299
Merged
Merged
Conversation
LysandreJik
approved these changes
Oct 22, 2024
LysandreJik
left a comment
LysandreJik
left a comment
Member
There was a problem hiding this comment.
Damn, thanks for solving this @stevhliu!
Member
|
Just a note that this won't be expanded. Maybe an opportunity to list the cache methods explicitly and provide one-liners for each one, in a followup PR? Happy to contribute if you're busy. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
fix generationconfigs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34273 #33756 to display all the
GenerationConfigparameters as shown here. Can be merged after #34293 which fixes the failingbuild_pr_documentationtest.