Skip to content

[i18n-ar] Translated file : docs/source/ar/trainer.md into Arabic#33080

Merged
stevhliu merged 53 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_trainer.md
Nov 9, 2024
Merged

[i18n-ar] Translated file : docs/source/ar/trainer.md into Arabic#33080
stevhliu merged 53 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_trainer.md

Conversation

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the docs/source/ar/trainer.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

@abodacs abodacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم
تمت المراجعة
@AhmedAlmaghz
جزاك الله خيرا

Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
AhmedAlmaghz and others added 24 commits November 1, 2024 19:49
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Thank you @abodacs

@AhmedAlmaghz
AhmedAlmaghz marked this pull request as ready for review November 1, 2024 20:51
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the translation!

Comment thread docs/source/ar/trainer.md
Comment thread docs/source/ar/trainer.md
@AhmedAlmaghz

AhmedAlmaghz commented Nov 5, 2024

Copy link
Copy Markdown
Contributor Author

The following pull requests have been added to the current pull request to be merged once

@abodacs , @stevhliu

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

أخي عبدالله @abodacs هذا ما تم إنجازه في هذا القسم
إلى الامام إن شاء الله

DEVELOPER GUIDES

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Please, merge this PR.
@stevhliu

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more formatting issues, then we should be ready 👍

Comment thread docs/source/ar/trainer.md Outdated
Comment thread docs/source/ar/trainer.md Outdated
@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Thank you @stevhliu

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevhliu
stevhliu merged commit 768f3c0 into huggingface:main Nov 9, 2024
@AhmedAlmaghz
AhmedAlmaghz deleted the Add_docs_source_ar_trainer.md branch November 9, 2024 20:40
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…uggingface#33080)

* Add docs/source/ar/trainer.md to Add_docs_source_ar_trainer.md

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update trainer.md

* Update trainer.md

* Update trainer.md

* Create _toctree.yml

* Delete docs/source/ar/_toctree.yml

* Update _toctree.yml - add trainer

* Update _toctree.yml

* merge serialization.md into this branch

* merge sagemaker.md into this PR

* Update _toctree.yml

* Update docs/source/ar/trainer.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ar/trainer.md

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants